From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258E1ECAAD3 for ; Sat, 17 Sep 2022 17:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiIQRBx (ORCPT ); Sat, 17 Sep 2022 13:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbiIQRBv (ORCPT ); Sat, 17 Sep 2022 13:01:51 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 217DE2CDC7 for ; Sat, 17 Sep 2022 10:01:50 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id u18so40341518lfo.8 for ; Sat, 17 Sep 2022 10:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Ig5ssViM1rEyXtUESEN89ct/IqJLFI2/i7+wSTnWs7I=; b=gMV4yJpOfyMOcH8d0EHCZ0RwYQ0797S6orU61WuIJ4fEjUcw1vxv8iVBzotacT6/I2 GzG2bKrbDOQv/lNRNAy2WPTFl2mI2hEVhdZqGXyzgYC26J1PHFg+n1t1ISdfnTWRAZRm PLNEa1fGkCtVQJvfMqxizH6Gpmv6M7ztaVkJrzMBSJ9lErUu8eSNQ7PJNjOTPfXveKIb iXGmNFwvn4UzsEm5pVZqqQ66WdjuCHTKkbASttuyD/y6mBJfXTjUjlGw/5SCj39vaivv A0m3ah3Gg5X+iJqQKJGvN4jhoIESA4dgEnBI4CgG9d3KOubPwkHXCkX1e8a5xvSjxRpV 9BsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Ig5ssViM1rEyXtUESEN89ct/IqJLFI2/i7+wSTnWs7I=; b=OX+50ATRGHAeGSYM0puXOTBsRyoXRXifqZhkU8RkHU40zH5ARr4wpVOH9K4QtK7pL7 eHyf3SJvOugpPzuxRecddIi/JK0SlqZ+trGzO2quQJunQvFl/PEPil9blkI2D/XdsRfc /0nEYVraf9hlIpCS2VkEOmxiHr1R7DxLa8nYCyIVFKhHnpzc/AJb13PNVNosCF2sULGb OF1hKFcDoT7a897oT9s4OkcFQIcpUS0eo5o2p4pTl5bZgjEEKA5fLD/HQEsF8hWn4m/m sjEy+Pn0WPKZ2NMgS893C+1C9k+CFVobV3jE1kYPYGmoGc3PZ5BCq87JOsREe1NSbyKB mpPA== X-Gm-Message-State: ACrzQf3uzu3Y8Ui4TkpYwCV7gcXu3YBUn1kkOiyLp431odDFw2w8Mf7J jYxHi527lVtAXs4/4C3JGDZqkA== X-Google-Smtp-Source: AMsMyM5xsPWU9tQoDsp6KN2ZZ9MgzVAhLKrcz5IWH83xPmQ8mgBvIV/ggD6Z682mm/XizJI3uTMifQ== X-Received: by 2002:ac2:5097:0:b0:498:f5b9:7a6f with SMTP id f23-20020ac25097000000b00498f5b97a6fmr3398509lfm.640.1663434108411; Sat, 17 Sep 2022 10:01:48 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id z2-20020ac24182000000b004948497e07esm4203460lfh.15.2022.09.17.10.01.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Sep 2022 10:01:47 -0700 (PDT) Message-ID: <9c1817f0-da79-7264-7fb6-31a518c3126a@linaro.org> Date: Sat, 17 Sep 2022 18:01:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [linux][PATCH v9 2/2] dts: arm: at91: Add SAMA5D3-EDS Board Content-Language: en-US To: Jerry.Ray@microchip.com, Claudiu.Beznea@microchip.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220909163022.13022-1-jerry.ray@microchip.com> <20220909163022.13022-2-jerry.ray@microchip.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/2022 15:53, Jerry.Ray@microchip.com wrote: >>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for >>> evaluating many Microchip ethernet switch and PHY products. Various >>> daughter cards can connect via an RGMII connector or an RMII connector. >>> >>> The EDS board is not intended for stand-alone use and has no ethernet >>> capabilities when no daughter board is connected. As such, this >>> device tree is intended to be used with a DT overlay defining the add-on board. >>> To better ensure consistency, some items are defined here as a form of >>> documentation so that all add-on overlays will use the same terms. >>> >>> Link: >>> https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVE >>> LOPMENT-SYSTEM >>> Signed-off-by: Jerry Ray >>> --- >>> v8->v9: >>> - Changed node name from gpio to gpio-inputs >> >> Why not gpio-keys as all other DTSes are doing? Anyway, I can change it while applying. >> >> Thank you, >> Claudiu Beznea >> > > gpio-keys is the compatible string name. I wanted the node name to be unique > for grep purposes. Node names should not be unique but generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > Regards, > Jerry. > >>> v7->v8: >>> - correcting patch subject line. >>> v6->v7: Please trim your replies... there is no need to quote everything after the comment. (snip) Best regards, Krzysztof