From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"gustavo@embeddedor.com" <gustavo@embeddedor.com>,
Eli Britstein <elibr@mellanox.com>, Roi Dayan <roid@mellanox.com>,
"leon@kernel.org" <leon@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH][next] net/mlx5e: Remove redundant assignment
Date: Mon, 18 Mar 2019 18:10:00 +0000 [thread overview]
Message-ID: <9c1a67b0c8e9c1e3a6448a9c3ac848c3b5d109b6.camel@mellanox.com> (raw)
In-Reply-To: <6cef0a46-d408-4b79-88ca-6c7da2538abf@embeddedor.com>
On Mon, 2019-03-18 at 12:35 -0500, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
Hi Gustavo,
I already replied on March 8, that this patch was applied to my branch,
net-next-mlx5,
https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=net-next-mlx5&id=6279999c6e3de5a93312a2d66b3fd6ac8636f260
Once net-next is open, this patch is going to make it there as part of
my next pull request to Dave.
Thanks,
Saeed.
> Thanks
> --
> Gustavo
>
> On 3/3/19 11:31 AM, Eli Britstein wrote:
> > Reviewed-by: Eli Britstein <elibr@mellanox.com>
> >
> > On 3/3/2019 5:20 PM, Roi Dayan wrote:
> > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote:
> > > > Remove redundant assignment to tun_entropy->enabled.
> > > >
> > > > Addesses-Coverity-ID: 1477328 ("Unused value")
> > > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling
> > > > port tunnel entropy calculation")
> > > the commit doesn't fix any real issue but is more of a cleanup.
> > > so I'm not sure if fixes line is relevant or not.
> > > beside that looks ok.
> > >
> > > Reviewed-by: Roi Dayan <roid@mellanox.com>
> > >
> > >
> > > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > > > ---
> > > > drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6
> > > > ++----
> > > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git
> > > > a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> > > > b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> > > > index 40f4a19b1ce1..be69c1d7941a 100644
> > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> > > > @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct
> > > > mlx5_tun_entropy *tun_entropy,
> > > > mlx5_query_port_tun_entropy(mdev, &entropy_flags);
> > > > tun_entropy->num_enabling_entries = 0;
> > > > tun_entropy->num_disabling_entries = 0;
> > > > - tun_entropy->enabled = entropy_flags.calc_enabled;
> > > > - tun_entropy->enabled =
> > > > - (entropy_flags.calc_supported) ?
> > > > - entropy_flags.calc_enabled : true;
> > > > + tun_entropy->enabled = entropy_flags.calc_supported ?
> > > > + entropy_flags.calc_enabled :
> > > > true;
> > > > }
> > > >
> > > > static int mlx5_set_entropy(struct mlx5_tun_entropy
> > > > *tun_entropy,
> > > >
next prev parent reply other threads:[~2019-03-18 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 19:39 [PATCH][next] net/mlx5e: Remove redundant assignment Gustavo A. R. Silva
2019-03-03 15:20 ` Roi Dayan
2019-03-03 17:31 ` Eli Britstein
2019-03-18 17:35 ` Gustavo A. R. Silva
2019-03-18 18:10 ` Saeed Mahameed [this message]
2019-03-18 19:25 ` Gustavo A. R. Silva
2019-03-04 6:26 ` Leon Romanovsky
2019-03-05 22:21 ` Saeed Mahameed
2019-03-06 3:03 ` David Miller
2019-03-09 0:27 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1a67b0c8e9c1e3a6448a9c3ac848c3b5d109b6.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=elibr@mellanox.com \
--cc=gustavo@embeddedor.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roid@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).