From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33BCC433F5 for ; Mon, 29 Nov 2021 10:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345331AbhK2KnA (ORCPT ); Mon, 29 Nov 2021 05:43:00 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:18219 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231773AbhK2Kk6 (ORCPT ); Mon, 29 Nov 2021 05:40:58 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1638182261; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=NfRWfQ/kjNZZNKYjAgXr3woDR9TbFsk4RacT+8xIke8=; b=lrgyGjSE9PiYUckDwY6xElgCSo4ZejO56w63xfd/XQcMyqT/P+zSXCurs4e3RWl/GyffZzvP qfq+R39ZJljh80hokN9ItXm3DgPozDdY3eBeaAleIGiSPFz2kosX/PbvG7x3PsTfcsUU9q+u tdgdYNiqGXsoiJFGAk0RlpRODL4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-east-1.postgun.com with SMTP id 61a4ad74135a8a9d0e4bcda4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 29 Nov 2021 10:37:40 GMT Sender: srivasam=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 24951C43616; Mon, 29 Nov 2021 10:37:40 +0000 (UTC) Received: from [10.242.143.72] (unknown [202.46.23.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0E59BC4338F; Mon, 29 Nov 2021 10:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 0E59BC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH v6 08/10] ASoC: dt-bindings: Add SC7280 lpass cpu bindings To: Rob Herring Cc: agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, Venkata Prasad Potturu References: <1637928282-2819-1-git-send-email-srivasam@codeaurora.org> <1637928282-2819-9-git-send-email-srivasam@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: <9c21dc98-6bbb-bf33-361c-a768d185f07a@codeaurora.org> Date: Mon, 29 Nov 2021 16:07:31 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2021 10:23 PM, Rob Herring wrote: Thanks for Your Time Rob!!! > On Fri, Nov 26, 2021 at 05:34:40PM +0530, Srinivasa Rao Mandadapu wrote: >> Add bindings for sc7280 lpass cpu driver which supports >> audio over i2s based speaker, soundwire based headset, msm dmics >> and HDMI Port. >> >> Signed-off-by: Srinivasa Rao Mandadapu >> Co-developed-by: Venkata Prasad Potturu >> Signed-off-by: Venkata Prasad Potturu >> --- >> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 69 +++++++++++++++++++--- >> 1 file changed, 61 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> index 1e23c0e..0f5a57c 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml >> @@ -22,35 +22,36 @@ properties: >> - qcom,lpass-cpu >> - qcom,apq8016-lpass-cpu >> - qcom,sc7180-lpass-cpu >> + - qcom,sc7280-lpass-cpu >> >> reg: >> - maxItems: 2 >> + maxItems: 5 >> description: LPAIF core registers >> >> reg-names: >> - maxItems: 2 >> + maxItems: 5 >> >> clocks: >> minItems: 3 >> - maxItems: 6 >> + maxItems: 7 >> >> clock-names: >> minItems: 3 >> - maxItems: 6 >> + maxItems: 7 >> >> interrupts: >> - maxItems: 2 >> + maxItems: 4 >> description: LPAIF DMA buffer interrupt >> >> interrupt-names: >> - maxItems: 2 >> + maxItems: 4 >> >> qcom,adsp: >> $ref: /schemas/types.yaml#/definitions/phandle >> description: Phandle for the audio DSP node >> >> iommus: >> - maxItems: 2 >> + maxItems: 3 >> description: Phandle to apps_smmu node with sid mask >> >> power-domains: >> @@ -69,7 +70,7 @@ patternProperties: >> "^dai-link@[0-9a-f]$": >> type: object >> description: | >> - LPASS CPU dai node for each I2S device. Bindings of each node >> + LPASS CPU dai node for each I2S device or Soundwire device. Bindings of each node >> depends on the specific driver providing the functionality and >> properties. >> properties: >> @@ -174,6 +175,58 @@ allOf: >> - iommus >> - power-domains >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,sc7280-lpass-cpu >> + >> + then: >> + properties: >> + clock-names: >> + oneOf: >> + - items: #for I2S >> + - const: lpass_aon_cc_audio_hm_h_clk >> + - const: lpass_core_cc_sysnoc_mport_core_clk >> + - const: lpass_core_cc_ext_if1_ibit_clk >> + - items: #for Soundwire >> + - const: lpass_aon_cc_audio_hm_h_clk >> + - const: lpass_audio_cc_codec_mem0_clk >> + - const: lpass_audio_cc_codec_mem1_clk >> + - const: lpass_audio_cc_codec_mem2_clk >> + - items: #for HDMI >> + - const: lpass_aon_cc_audio_hm_h_clk > 'lpass_' and '_clk' are redundant. Yes. but these clock names are defined by HW design team. clock drivers fallowed the same,  hence in audio drivers. > >> + >> + reg-names: >> + anyOf: >> + - items: #for I2S >> + - const: lpass-lpaif >> + - items: #for I2S and HDMI >> + - const: lpass-hdmiif >> + - const: lpass-lpaif > Doesn't this apply to other SoCs? > >> + - items: #for I2S, soundwire and HDMI >> + - const: lpass-cdc-lpm >> + - const: lpass-rxtx-lpaif >> + - const: lpass-va-lpaif >> + - const: lpass-hdmiif >> + - const: lpass-lpaif > 'lpass-' is redundant too, but consistency across SoCs is better. > > hdmiif and lpaif should be first. (Add new resources on the end.) Okay.. order is maintained as per register addresses. if it's okay, even address range is out of order, will change accordingly. > >> + interrupt-names: >> + anyOf: >> + - items: #for I2S >> + - const: lpass-irq-lpaif >> + - items: #for I2S and HDMI >> + - const: lpass-irq-lpaif >> + - const: lpass-irq-hdmi >> + - items: #for I2S, soundwire and HDMI >> + - const: lpass-irq-lpaif >> + - const: lpass-irq-vaif >> + - const: lpass-irq-rxtxif >> + - const: lpass-irq-hdmi > Again, add new entries to the end.  Replied above for the same. >> + >> + required: >> + - iommus >> + - power-domains >> + >> examples: >> - | >> #include >> -- >> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., >> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >> >> -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.