From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8E5C3B1BF for ; Mon, 17 Feb 2020 02:22:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4374F22522 for ; Mon, 17 Feb 2020 02:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbgBQCWa (ORCPT ); Sun, 16 Feb 2020 21:22:30 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:50006 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726183AbgBQCWa (ORCPT ); Sun, 16 Feb 2020 21:22:30 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 39052640039451A6E54E; Mon, 17 Feb 2020 10:22:28 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Feb 2020 10:22:23 +0800 Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called To: Jaegeuk Kim , , References: <20200214185855.217360-1-jaegeuk@kernel.org> <20200214185855.217360-3-jaegeuk@kernel.org> From: Chao Yu Message-ID: <9c497f3e-3399-e4a6-f81c-6c4a1f35e5bb@huawei.com> Date: Mon, 17 Feb 2020 10:22:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200214185855.217360-3-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/2/15 2:58, Jaegeuk Kim wrote: > FG_GC needs to move entire section more quickly. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index bbf4db3f6bb4..1676eebc8c8b 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1203,7 +1203,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > > if (get_valid_blocks(sbi, segno, false) == 0) > goto freed; > - if (__is_large_section(sbi) && > + if (gc_type == BG_GC && __is_large_section(sbi) && > migrated >= sbi->migration_granularity) I knew migrating one large section is a more efficient way, but this can increase long-tail latency of f2fs_balance_fs() occasionally, especially in extreme fragmented space. Thanks, > goto skip; > if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi))) >