From: David Vrabel <david.vrabel@citrix.com>
To: Olaf Hering <olaf@aepfle.de>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: <konrad.wilk@oracle.com>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>, <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing
Date: Thu, 10 Nov 2016 17:49:21 +0000 [thread overview]
Message-ID: <9c5d23e9-cb02-5f83-0422-2bbf55fb7779@citrix.com> (raw)
In-Reply-To: <20161110174734.GB5937@aepfle.de>
On 10/11/16 17:47, Olaf Hering wrote:
> On Thu, Nov 10, Boris Ostrovsky wrote:
>
>> Are you sure it's this patch that causes the failure?
>>
>> I commented out '| VM_IO' and still unable to boot with this option.
>
> Yes, this works for me, sles12sp2 dom0+domU, which is linux-4.4 based:
>
> +++ b/drivers/xen/gntdev.c
> @@ -804,7 +804,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
>
> vma->vm_ops = &gntdev_vmops;
>
> - vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP | VM_IO;
> + vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP /*| VM_IO*/;
>
> if (use_ptemod)
> vma->vm_flags |= VM_DONTCOPY;
I think we need a custom policy for this VMA with MPOL_F_MOF cleared.
David
next prev parent reply other threads:[~2016-11-10 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 20:10 [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing Boris Ostrovsky
2015-11-26 17:48 ` [Xen-devel] " David Vrabel
2016-11-10 16:26 ` Olaf Hering
2016-11-10 16:39 ` Boris Ostrovsky
2016-11-10 16:42 ` Olaf Hering
2016-11-10 17:34 ` Boris Ostrovsky
2016-11-10 17:47 ` Olaf Hering
2016-11-10 17:49 ` David Vrabel [this message]
2016-11-10 18:09 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c5d23e9-cb02-5f83-0422-2bbf55fb7779@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).