From: Tianyu Lan <ltykernel@gmail.com>
To: Jinank Jain <jinankjain@linux.microsoft.com>,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, daniel.lezcano@linaro.org, arnd@arndb.de,
michael.h.kelley@microsoft.com
Cc: Tianyu Lan <tiala@microsoft.com>,
linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, vkuznets@redhat.com,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH V3 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP enlightened guest
Date: Wed, 26 Jul 2023 22:15:27 +0800 [thread overview]
Message-ID: <9c690209-4a1c-842f-064b-66ae5c8d870f@gmail.com> (raw)
In-Reply-To: <4d0715a5-70a8-9667-ccf0-de9bc933bb04@linux.microsoft.com>
On 7/26/2023 12:26 PM, Jinank Jain wrote:
>> + /*
>> + * Hyper-V SEV-SNP enlightened guest doesn't support ioapic
>> + * and legacy APIC page read/write. Switch to hv apic here.
>> + */
>> + disable_ioapic_support();
>
> Where are we switching hv_apic? May I am missing something here?
>
Nice catch! It's fossil comment when there is no x2apic support.
Will fix it in the next version.
next prev parent reply other threads:[~2023-07-26 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 3:22 [PATCH V3 0/9] x86/hyperv: Add AMD sev-snp enlightened guest support on hyperv Tianyu Lan
2023-07-18 3:22 ` [PATCH V3 1/9] x86/hyperv: Add sev-snp enlightened guest static key Tianyu Lan
2023-07-26 3:26 ` Michael Kelley (LINUX)
2023-07-18 3:22 ` [PATCH V3 2/9] x86/hyperv: Set Virtual Trust Level in VMBus init message Tianyu Lan
2023-07-26 3:28 ` Michael Kelley (LINUX)
2023-07-18 3:22 ` [PATCH V3 3/9] x86/hyperv: Mark Hyper-V vp assist page unencrypted in SEV-SNP enlightened guest Tianyu Lan
2023-07-18 3:22 ` [PATCH V3 4/9] drivers: hv: Mark percpu hvcall input arg " Tianyu Lan
2023-07-18 3:22 ` [PATCH V3 5/9] x86/hyperv: Use vmmcall to implement Hyper-V hypercall in sev-snp " Tianyu Lan
2023-07-26 3:44 ` Michael Kelley (LINUX)
2023-07-26 13:47 ` Tianyu Lan
2023-07-26 14:29 ` Michael Kelley (LINUX)
2023-07-28 10:45 ` Tianyu Lan
2023-07-18 3:23 ` [PATCH V3 6/9] clocksource: hyper-v: Mark hyperv tsc page unencrypted " Tianyu Lan
2023-07-18 3:23 ` [PATCH V3 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP " Tianyu Lan
2023-07-26 4:26 ` Jinank Jain
2023-07-26 14:15 ` Tianyu Lan [this message]
2023-07-18 3:23 ` [PATCH V3 8/9] x86/hyperv: Add smp support for SEV-SNP guest Tianyu Lan
2023-07-18 3:23 ` [PATCH V3 9/9] x86/hyperv: Add hyperv-specific handling for VMMCALL under SEV-ES Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c690209-4a1c-842f-064b-66ae5c8d870f@gmail.com \
--to=ltykernel@gmail.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jinankjain@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tiala@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).