From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbcGYUs6 (ORCPT ); Mon, 25 Jul 2016 16:48:58 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:36749 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882AbcGYUs4 (ORCPT ); Mon, 25 Jul 2016 16:48:56 -0400 Subject: Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open To: Jiri Kosina References: <20160610230255.GA27770@djo.tudelft.nl> <20160614184308.GA6188@djo.tudelft.nl> <20160615132040.GZ14480@ZenIV.linux.org.uk> <20160615224722.GA9545@djo.tudelft.nl> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Wim Osterholt From: Jens Axboe Message-ID: <9c713fa8-9da1-47b5-0d5d-92f4cd13493a@kernel.dk> Date: Mon, 25 Jul 2016 14:48:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30/2016 05:18 AM, Jiri Kosina wrote: > From: Jiri Kosina > > Commit 09954bad4 ("floppy: refactor open() flags handling"), as a > side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that > this is being used setfdprm userspace for ioctl-only open(). > > Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE) > modes, while still keeping the original O_NDELAY bug fixed. > > Cc: stable@vger.kernel.org # v4.5+ > Reported-by: Wim Osterholt > Tested-by: Wim Osterholt > Signed-off-by: Jiri Kosina Added for this series, thanks. -- Jens Axboe