From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920BFC197BF for ; Mon, 7 Dec 2020 15:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FD9023741 for ; Mon, 7 Dec 2020 15:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727017AbgLGPux (ORCPT ); Mon, 7 Dec 2020 10:50:53 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:51704 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgLGPuv (ORCPT ); Mon, 7 Dec 2020 10:50:51 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: andrzej.p) with ESMTPSA id 79D0D1F44D66 Subject: Re: [PATCH v4 2/7] Input: use input_device_enabled() To: Marek Szyprowski , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kukjin Kim , Krzysztof Kozlowski , Dmitry Torokhov , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Sylvain Lemieux , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Barry Song , Michael Hennerich , Nick Dyer , Hans de Goede , Ferruh Yigit , Sangwon Jee , Peter Hutterer , Henrique de Moraes Holschuh , kernel@collabora.com, Bartlomiej Zolnierkiewicz References: <2336e15d-ff4b-bbb6-c701-dbf3aa110fcd@redhat.com> <20200608112211.12125-1-andrzej.p@collabora.com> <20200608112211.12125-3-andrzej.p@collabora.com> <27ce1176-6318-45aa-4e22-3dec9f3df15d@samsung.com> From: Andrzej Pietrasiewicz Message-ID: <9c784a23-eade-eacd-3e67-d344a5758b83@collabora.com> Date: Mon, 7 Dec 2020 16:50:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <27ce1176-6318-45aa-4e22-3dec9f3df15d@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze: > Hi Andrzej, > > On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote: >> Use the newly added helper in relevant input drivers. >> >> Signed-off-by: Andrzej Pietrasiewicz > > This patch landed recently in linux-next as commit d69f0a43c677 ("Input: > use input_device_enabled()"). Sadly it causes following warning during > system suspend/resume cycle on ARM 32bit Samsung Exynos5250-based Snow > Chromebook with kernel compiled from exynos_defconfig: > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1777 at drivers/input/input.c:2230 > input_device_enabled+0x68/0x6c > Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic > libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc > exynos_gsc v4l2_mem2mem videob > CPU: 0 PID: 1777 Comm: rtcwake Not tainted > 5.10.0-rc6-next-20201207-00001-g49a0dc04c46d-dirty #9902 > Hardware name: Samsung Exynos (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0xb4/0xd4) > [] (dump_stack) from [] (__warn+0xd8/0x11c) > [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) > [] (warn_slowpath_fmt) from [] > (input_device_enabled+0x68/0x6c) > [] (input_device_enabled) from [] Apparently you are hitting this line of code in drivers/input/input.c: lockdep_assert_held(&dev->mutex); Inspecting input device's "users" member should happen under dev's lock. Regards, Andrzej