From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445AbcFVMwV (ORCPT ); Wed, 22 Jun 2016 08:52:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:47657 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbcFVMwT (ORCPT ); Wed, 22 Jun 2016 08:52:19 -0400 Subject: Re: [PATCH 03/27] mm, vmscan: Move LRU lists to node To: Mel Gorman , Andrew Morton , Linux-MM References: <1466518566-30034-1-git-send-email-mgorman@techsingularity.net> <1466518566-30034-4-git-send-email-mgorman@techsingularity.net> Cc: Rik van Riel , Johannes Weiner , LKML From: Vlastimil Babka Message-ID: <9c85cef1-32cc-5b99-0b95-8c8f0b14fd65@suse.cz> Date: Wed, 22 Jun 2016 14:50:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466518566-30034-4-git-send-email-mgorman@techsingularity.net> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2016 04:15 PM, Mel Gorman wrote: > This moves the LRU lists from the zone to the node and related data > such as counters, tracing, congestion tracking and writeback tracking. > Unfortunately, due to reclaim and compaction retry logic, it is necessary > to account for the number of LRU pages on both zone and node logic. Most > reclaim logic is based on the node counters but the retry logic uses > the zone counters which do not distinguish inactive and inactive sizes. > It would be possible to leave the LRU counters on a per-zone basis but > it's a heavier calculation across multiple cache lines that is much > more frequent than the retry checks. > > Other than the LRU counters, this is mostly a mechanical patch but note > that it introduces a number of anomalies. For example, the scans are > per-zone but using per-node counters. We also mark a node as congested > when a zone is congested. This causes weird problems that are fixed later > but is easier to review. > > Signed-off-by: Mel Gorman > Acked-by: Johannes Weiner Acked-by: Vlastimil Babka