From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A257FC282E1 for ; Thu, 23 May 2019 22:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B072177E for ; Thu, 23 May 2019 22:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558652237; bh=WFHx5fEpakFET6xE99iCq+IHCGjIpUrxMJE09DB+6tw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=x/pzcKIZRXKbgEIAJiCsiJoksm1kaKsbEPA1j5H/Z9HMY3n0BiLzn2BiWqD4WydcU 61GbRN20g7zUlMCTOhibRX0+8MxBi4eWs5Bx7+YDawn1yYGb7FuQS154VjI6G4y4mS /yyy7FXIIc/qCC04OW3kNEMgY621hoDB23MM/qvE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388667AbfEWW5Q (ORCPT ); Thu, 23 May 2019 18:57:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:42128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388006AbfEWW5Q (ORCPT ); Thu, 23 May 2019 18:57:16 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F98B20863; Thu, 23 May 2019 22:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558652235; bh=WFHx5fEpakFET6xE99iCq+IHCGjIpUrxMJE09DB+6tw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=D5+ZXtMX69SZtQ3RHb+/n6c/6ZB4HUNdQkYRnT3WAiMa7EvJPUBS0FhOlVVt8c5BR 7pagjqt/Wax8FLqNuDeZCAVm0WRD9qiWIOdJS7T9KL/NHDxXuLO/EjScQJhHIpOs94 ntEyQsgYt8yC34FPc2D5jvWNznH74wHuAHD49pd4= Subject: Re: [PATCH 0/2] kselftest: fix rtctest timeout To: Alexandre Belloni Cc: Kees Cook , Jeffrin Thalakkottoor , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, shuah References: <20190523224223.11054-1-alexandre.belloni@bootlin.com> From: shuah Message-ID: <9c94c2b7-153d-ef75-c474-9bae49d6a039@kernel.org> Date: Thu, 23 May 2019 16:57:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523224223.11054-1-alexandre.belloni@bootlin.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/19 4:42 PM, Alexandre Belloni wrote: > Hi, > > Commit a745f7af3cbd ("selftests/harness: Add 30 second timeout per > test") wrongly assumed that no individual test would run for more than > 30 seconds and this silently broke rtctest. > > Please consider the following patches as fixes for v5.2 to avoid having > any non working release. > > Thanks, > > Alexandre Belloni (2): > selftests/harness: Allow test to configure timeout > selftests: rtc: rtctest: specify timeouts > > tools/testing/selftests/kselftest_harness.h | 17 ++++++++++++----- > tools/testing/selftests/rtc/rtctest.c | 6 +++--- > 2 files changed, 15 insertions(+), 8 deletions(-) > Thanks for fixing them quickly. I will pull these in. I have one more fix from Kees already queued up. Jeffrin! Would you like to test these to see if they work for you and send Tested-by tag. I don't see 1/2 in my Inbox. I have Kees's reply to it. Odd. thanks, -- Shuah