From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF
Date: Thu, 5 Nov 2020 08:58:45 +0000 [thread overview]
Message-ID: <9cadea52ab4a19d004222c88d68d25cf425bb9a7.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20201105082328.GV4488@dell>
On Thu, 2020-11-05 at 08:23 +0000, Lee Jones wrote:
> On Wed, 04 Nov 2020, Lee Jones wrote:
>
> > On Wed, 28 Oct 2020, Matti Vaittinen wrote:
> >
> > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are
> > > mainly used to power the R-Car series processors.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > > drivers/mfd/Kconfig | 11 +++
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/rohm-bd9576.c | 130
> > > +++++++++++++++++++++++++++++++
> > > include/linux/mfd/rohm-bd957x.h | 59 ++++++++++++++
> > > include/linux/mfd/rohm-generic.h | 2 +
> > > 5 files changed, 203 insertions(+)
> > > create mode 100644 drivers/mfd/rohm-bd9576.c
> > > create mode 100644 include/linux/mfd/rohm-bd957x.h
>
> [...]
>
> > > +static const struct regmap_range volatile_ranges[] = {
> > > + {
> > > + .range_min = BD957X_REG_SMRB_ASSERT,
> > > + .range_max = BD957X_REG_SMRB_ASSERT,
> > > + },
> > > + {
> >
> > The way you space your braces is not consistent.
> >
> > > + .range_min = BD957X_REG_PMIC_INTERNAL_STAT,
> > > + .range_max = BD957X_REG_PMIC_INTERNAL_STAT,
> > > + },
> > > + {
> > > + .range_min = BD957X_REG_INT_THERM_STAT,
> > > + .range_max = BD957X_REG_INT_THERM_STAT,
> > > + },
> > > + {
> > > + .range_min = BD957X_REG_INT_OVP_STAT,
> > > + .range_max = BD957X_REG_INT_SYS_STAT,
> > > + }, {
> > > + .range_min = BD957X_REG_INT_MAIN_STAT,
> > > + .range_max = BD957X_REG_INT_MAIN_STAT,
> > > + },
> > > +};
>
> Don't forget about this.
>
> I would prefer to have the braces on the same line (even if it means
> you have to change an extra line when editing), but I'm not 100% dead
> set on it. Consistency however, I am.
>
I won't forget. I intended to write that I was Ok with all the other
comments. Maybe I forgot though. Anyways, I'll fix the inconsistency -
thanks for pointing it out!
--Matti
next prev parent reply other threads:[~2020-11-05 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:45 [PATCH v4 0/4] Support ROHM BD9576MUF and BD9573MUF PMICs Matti Vaittinen
2020-10-28 9:46 ` [PATCH v4 1/4] dt_bindings: mfd: Add " Matti Vaittinen
2020-10-28 9:46 ` [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF Matti Vaittinen
2020-11-04 15:51 ` Lee Jones
2020-11-05 6:46 ` Vaittinen, Matti
2020-11-05 7:40 ` Vaittinen, Matti
2020-11-05 8:21 ` Lee Jones
2020-11-05 8:56 ` Vaittinen, Matti
2020-11-05 8:58 ` Lee Jones
2020-11-05 10:00 ` Vaittinen, Matti
2020-11-05 8:23 ` Lee Jones
2020-11-05 8:58 ` Vaittinen, Matti [this message]
2020-10-28 9:48 ` [PATCH v4 3/4] wdt: Support wdt on " Matti Vaittinen
2020-10-28 9:49 ` [PATCH v4 4/4] MAINTAINERS: Add ROHM BD9576MUF and BD9573MUF drivers Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cadea52ab4a19d004222c88d68d25cf425bb9a7.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).