From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3E0C4BA10 for ; Wed, 26 Feb 2020 13:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2A942468C for ; Wed, 26 Feb 2020 13:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727426AbgBZNzT (ORCPT ); Wed, 26 Feb 2020 08:55:19 -0500 Received: from foss.arm.com ([217.140.110.172]:36280 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbgBZNzT (ORCPT ); Wed, 26 Feb 2020 08:55:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A59B30E; Wed, 26 Feb 2020 05:55:19 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 969CC3F9E6; Wed, 26 Feb 2020 05:55:17 -0800 (PST) Subject: Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks To: Matthias Kaehlcke , Sharat Masetty Cc: devicetree@vger.kernel.org, dianders@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, dri-devel@freedesktop.org, freedreno@lists.freedesktop.org, will@kernel.org, iommu@lists.linux-foundation.org References: <1582186342-3484-1-git-send-email-smasetty@codeaurora.org> <1582186342-3484-2-git-send-email-smasetty@codeaurora.org> <20200220210242.GC24720@google.com> From: Robin Murphy Message-ID: <9cb8551f-becd-d84e-e0ce-43f13b84ad89@arm.com> Date: Wed, 26 Feb 2020 13:55:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200220210242.GC24720@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ /me fires off MAINTAINERS patch... ] On 20/02/2020 9:02 pm, Matthias Kaehlcke wrote: > On Thu, Feb 20, 2020 at 01:42:22PM +0530, Sharat Masetty wrote: >> This patch adds a clock definition needed for powering on the GPU TBUs >> and the GPU TCU. >> >> Signed-off-by: Sharat Masetty >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 6515dbe..235c0df 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -28,6 +28,7 @@ properties: >> - enum: >> - qcom,msm8996-smmu-v2 >> - qcom,msm8998-smmu-v2 >> + - qcom,sc7180-smmu-v2 > > The addition of the compatible string isn't (directly) related with $subject, > this should be done in a separate patch. ...or the patch should just be accurately described as "add support for new variant X, which requires an additional clock Y". And speaking of which, can anyone clarify how "TCU and TBU core clock" manages to abbreviate to "mem_iface_clk"? I would have naively assumed something like "core" would be most logical. Robin.