From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Rob Herring <robh@kernel.org>,
Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: touchscreen: Add HY46XX bindings
Date: Thu, 1 Apr 2021 20:37:13 +0200 [thread overview]
Message-ID: <9cd14c69-9c30-a68c-dfd1-396613b5185a@micronovasrl.com> (raw)
In-Reply-To: <20210306194120.GA1075725@robh.at.kernel.org>
Hello Rob, All,
Il 06/03/2021 20:41, Rob Herring ha scritto:
> On Fri, Mar 05, 2021 at 05:38:33PM +0100, Giulio Benetti wrote:
>> From: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>
>> This adds device tree bindings for the Hycon HY46XX touchscreen series.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> ---
>> .../input/touchscreen/hycon,hy46xx.yaml | 130 ++++++++++++++++++
>> MAINTAINERS | 6 +
>> 2 files changed, 136 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml b/Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml
>> new file mode 100644
>> index 000000000000..cddd5e5bae92
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml
>> @@ -0,0 +1,130 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/input/touchscreen/hycon-hy46xx.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: hyconon HY46XX series touchscreen controller Bindings
>> +
>> +description: |
>> + There are 6 variants of the chip for various touch panel sizes and coverl len material
>> + Glass: 0.3mm--4.0mm
>> + PET/PMMA: 0.2mm--2.0mm
>> + HY4613(B)-N048 < 6"
>> + HY4614(B)-N068 7" .. 10.1"
>> + HY4621-NS32 < 5"
>> + HY4623-NS48 5.1" .. 7"
>> + Glass: 0.3mm--8.0mm
>> + PET/PMMA: 0.2mm--4.0mm
>> + HY4633(B)-N048 < 6"
>> + HY4635(B)-N048 < 7" .. 10.1"
>> +
>> +maintainers:
>> + - Giulio Benetti <giulio.benetti@micronovasrl.com>
>> +
>> +allOf:
>> + - $ref: touchscreen.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - hycon,hycon-hy4613
>> + - hycon,hycon-hy4614
>> + - hycon,hycon-hy4621
>> + - hycon,hycon-hy4623
>> + - hycon,hycon-hy4633
>> + - hycon,hycon-hy4635
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + reset-gpios:
>> + maxItems: 1
>> +
>> + vcc-supply: true
>> +
>> + threshold:
>
> Needs a vendor prefix here and all the custom properties.
Sorry but I can't understand this ^^^, I've checked a lot of other yaml
files but couldn't find something related to this. Can you help me by
pointing me an example?
>
> One of the touchscreen properties doesn't already address this?
>
>> + description: Allows setting the sensitivity in the range from 0 to 255.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 255
>> +
>> + proximity-sensor-switch:
>
> Why a switch rather than enable or disable?
I've changed its name into enable.
>
>> + description: Allows enabling or disabling the Proximity Sensor.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 1
>
> Is this a hardware config or something a user would want to change at
> runtime? The latter shouldn't be in DT.
It's a hardware config that enable the 11th touch point, but I didn't
handle it inside the driver, so it's better that I remove it for the
moment.
> What does not present mean? Unless there is a need for keeping the
> default setting, then this could be boolean instead.
I've changed all "enable" to boolean and rely on default of the
controller.
Does this sound ok for you so I can send a v2 patchset?
Thank you
Best regards
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
> Same questions for the rest of the properties.
>> +
>> + glove-enable:
>> + description: Allows enabling or disabling glove setting.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 1
>> +
>> + report-speed:
>> + description: Allows setting the report speed(i.e 0x64 => 100Hz).
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 255
>> +
>> + power-noise-enable:
>> + description: Allows enabling or disabling power noise filter.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 1
>> +
>> + filter-data:
>> + description: Allows setting the filtering data before reporting touch
>> + in the range from 0 to 5.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 5
>> +
>> + gain:
>> + description: Allows setting the sensitivity distance in the range from 0 to 5.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 5
>> +
>> + edge-offset:
>> + description: Allows setting the edge compensation in the range from 0 to 16.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 16
>> +
>> + touchscreen-size-x: true
>> + touchscreen-size-y: true
>> + touchscreen-fuzz-x: true
>> + touchscreen-fuzz-y: true
>> + touchscreen-inverted-x: true
>> + touchscreen-inverted-y: true
>> + touchscreen-swapped-x-y: true
>> + interrupt-controller: true
>> +
>> +additionalProperties: false
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + hycon-hy4633@1c {
>> + compatible = "hycon,hy4633";
>> + reg = <0x1c>;
>> + interrupt-parent = <&gpio2>;
>> + interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
>> + reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d92f85ca831d..3f83daf6b2bf 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -8245,6 +8245,12 @@ S: Maintained
>> F: mm/hwpoison-inject.c
>> F: mm/memory-failure.c
>>
>> +HYCON HY46XX TOUCHSCREEN SUPPORT
>> +M: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> +L: linux-input@vger.kernel.org
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml
>> +
>> HYGON PROCESSOR SUPPORT
>> M: Pu Wen <puwen@hygon.cn>
>> L: linux-kernel@vger.kernel.org
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-04-01 18:52 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210305163834.70924-1-giulio.benetti@benettiengineering.com>
2021-03-05 16:38 ` [PATCH 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-03-05 17:25 ` Jonathan Neuschäfer
2021-03-05 17:33 ` Giulio Benetti
2021-03-05 19:32 ` Giulio Benetti
2021-03-05 16:38 ` [PATCH 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-03-05 19:34 ` Giulio Benetti
2021-03-06 19:28 ` Rob Herring
2021-03-06 19:41 ` Rob Herring
2021-04-01 18:37 ` Giulio Benetti [this message]
2021-04-01 22:24 ` Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-02 8:36 ` Jonathan Neuschäfer
2021-04-02 15:17 ` Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 3/3] Input: add driver for the Hycon HY46XX touchpanel series Giulio Benetti
2021-04-02 8:59 ` Jonathan Neuschäfer
2021-04-02 15:23 ` Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-06 13:24 ` Rob Herring
2021-04-07 17:57 ` Giulio Benetti
2021-04-07 18:56 ` Rob Herring
2021-04-07 19:17 ` Giulio Benetti
2021-04-06 13:37 ` Jonathan Neuschäfer
2021-04-06 14:07 ` Giulio Benetti
2021-04-07 17:49 ` [PATCH v4 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-07 17:49 ` [PATCH v4 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-08 20:16 ` Rob Herring
2021-04-07 17:49 ` [PATCH v4 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-08 20:21 ` Rob Herring
2021-04-11 11:37 ` Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-12 15:05 ` Rob Herring
2021-04-12 15:12 ` Giulio Benetti
2021-04-13 13:35 ` Rob Herring
2021-04-13 14:44 ` [PATCH v7 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-13 14:44 ` [PATCH v7 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-14 5:44 ` Dmitry Torokhov
2021-04-13 14:44 ` [PATCH v7 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-13 16:36 ` Rob Herring
2021-04-14 5:44 ` Dmitry Torokhov
2021-04-13 14:44 ` [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series Giulio Benetti
2021-04-14 5:44 ` Dmitry Torokhov
2021-04-14 6:46 ` Peter Hutterer
2021-04-14 11:22 ` Giulio Benetti
2021-04-14 17:26 ` Dmitry Torokhov
2021-04-15 6:16 ` Peter Hutterer
2021-04-14 11:24 ` Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-12 13:20 ` Rob Herring
2021-04-12 14:46 ` Rob Herring
2021-04-12 14:49 ` Giulio Benetti
2021-04-12 15:23 ` [PATCH v6 0/2] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-12 15:23 ` [PATCH v6 1/2] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-13 15:07 ` Rob Herring
2021-04-13 15:27 ` Giulio Benetti
2021-04-13 17:58 ` Rob Herring
2021-04-13 18:34 ` Giulio Benetti
2021-04-12 15:24 ` [PATCH v6 2/2] Input: add driver for the Hycon HY46XX touchpanel series Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 3/3] " Giulio Benetti
2021-04-07 17:49 ` [PATCH v4 " Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 " Giulio Benetti
2021-03-05 16:38 ` [PATCH " Giulio Benetti
2021-03-05 19:00 ` Dmitry Torokhov
2021-03-05 19:31 ` Giulio Benetti
2021-03-05 19:54 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd14c69-9c30-a68c-dfd1-396613b5185a@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).