From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
To: John Fastabend <john.fastabend@gmail.com>,
Dave Taht <dave.taht@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Martin Elshuber <martin.elshuber@theobroma-systems.com>
Subject: Re: [bug, bisected] pfifo_fast causes packet reordering
Date: Thu, 22 Mar 2018 11:16:08 +0100 [thread overview]
Message-ID: <9cf7a278-7269-9571-c378-ad98a5cd281b@theobroma-systems.com> (raw)
In-Reply-To: <ffdc6ca9-bf64-5514-bac9-7b107f9b443b@gmail.com>
On 21.03.18 21:52, John Fastabend wrote:
> Can you try this,
>
> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
> index d4907b5..1e596bd 100644
> --- a/include/net/sch_generic.h
> +++ b/include/net/sch_generic.h
> @@ -30,6 +30,7 @@ struct qdisc_rate_table {
> enum qdisc_state_t {
> __QDISC_STATE_SCHED,
> __QDISC_STATE_DEACTIVATED,
> + __QDISC_STATE_RUNNING,
> };
> [...]
Tested, looks good. No OOO observed, no side effects observed, iperf
numbers on Gigabit Ethernet look the same.
Thanks,
Jakob
next prev parent reply other threads:[~2018-03-22 10:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 18:24 [bug, bisected] pfifo_fast causes packet reordering Jakob Unterwurzacher
2018-03-13 18:35 ` Dave Taht
2018-03-14 4:03 ` John Fastabend
2018-03-14 10:09 ` Jakob Unterwurzacher
2018-03-15 18:08 ` Jakob Unterwurzacher
2018-03-15 22:30 ` John Fastabend
2018-03-16 10:26 ` Jakob Unterwurzacher
2018-03-19 6:07 ` Alexander Stein
2018-03-19 12:32 ` Paolo Abeni
2018-03-19 12:56 ` Jakob Unterwurzacher
2018-03-21 10:01 ` Jakob Unterwurzacher
2018-03-21 18:43 ` John Fastabend
2018-03-21 19:44 ` Jakob Unterwurzacher
2018-03-21 20:52 ` John Fastabend
2018-03-22 10:16 ` Jakob Unterwurzacher [this message]
2018-03-24 14:26 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf7a278-7269-9571-c378-ad98a5cd281b@theobroma-systems.com \
--to=jakob.unterwurzacher@theobroma-systems.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.elshuber@theobroma-systems.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).