From: Dmitry Osipenko <digetx@gmail.com>
To: Gwendal Grignou <gwendal@chromium.org>,
bleung@chromium.org, enric.balletbo@collabora.com,
groeck@chromium.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings
Date: Fri, 27 Aug 2021 08:21:32 +0300 [thread overview]
Message-ID: <9d000f0c-ef4a-e92a-44ee-6a887d45f70b@gmail.com> (raw)
In-Reply-To: <20210825181802.2838484-1-gwendal@chromium.org>
25.08.2021 21:18, Gwendal Grignou пишет:
> Fix printf format issues in new tracing events.
>
> Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes since v1:
> - Use %u instead of %d for ec timestamp, it is presented as a u32.
>
> drivers/platform/chrome/cros_ec_trace.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
> index f50b9f9b8610..9d0c848af310 100644
> --- a/drivers/platform/chrome/cros_ec_trace.h
> +++ b/drivers/platform/chrome/cros_ec_trace.h
> @@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp,
> __entry->current_time = current_time;
> __entry->delta = current_timestamp - current_time;
> ),
> - TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> + TP_printk("ec_ts: %9d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
ec_ts unsigned
> __entry->ec_sample_timestamp,
> __entry->ec_fifo_timestamp,
> __entry->fifo_timestamp,
> @@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data,
> __entry->current_time = current_time;
> __entry->delta = current_timestamp - current_time;
> ),
> - TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> + TP_printk("ec_num: %4d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
ec_num unsigned
next prev parent reply other threads:[~2021-08-27 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 18:18 [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings Gwendal Grignou
2021-08-27 5:21 ` Dmitry Osipenko [this message]
2021-08-30 18:01 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d000f0c-ef4a-e92a-44ee-6a887d45f70b@gmail.com \
--to=digetx@gmail.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).