linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sanjay R Mehta <sanmehta@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Sanjay R Mehta <Sanju.Mehta@amd.com>
Cc: vkoul@kernel.org, dan.j.williams@intel.com,
	Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com,
	Nehal-bakulchandra.Shah@amd.com, robh@kernel.org,
	mchehab+samsung@kernel.org, davem@davemloft.net,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v11 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA
Date: Thu, 5 Aug 2021 18:55:25 +0530	[thread overview]
Message-ID: <9d109c82-4c73-6e8e-ee8d-c6287495dc92@amd.com> (raw)
In-Reply-To: <YQvYeorB7BniIdm2@kroah.com>



On 8/5/2021 5:54 PM, Greg KH wrote:
> [CAUTION: External Email]
> 
> On Mon, Aug 02, 2021 at 05:32:55AM -0500, Sanjay R Mehta wrote:
>> +void ptdma_debugfs_setup(struct pt_device *pt)
>> +{
>> +     struct pt_cmd_queue *cmd_q;
>> +     char name[MAX_NAME_LEN + 1];
>> +     struct dentry *debugfs_q_instance;
>> +
>> +     if (!debugfs_initialized())
>> +             return;
>> +
>> +     debugfs_create_file("info", 0400, pt->dma_dev.dbg_dev_root, pt,
>> +                         &pt_debugfs_info_fops);
>> +
>> +     debugfs_create_file("stats", 0400, pt->dma_dev.dbg_dev_root, pt,
>> +                         &pt_debugfs_stats_fops);
>> +
>> +     cmd_q = &pt->cmd_q;
>> +
>> +     snprintf(name, MAX_NAME_LEN - 1, "q");
> 
> You are calling snprintf() to format a string to be "q"?  Why?  You can
> just do:
> 
>> +
>> +     debugfs_q_instance =
>> +             debugfs_create_dir(name, pt->dma_dev.dbg_dev_root);
> 
> debugfs_create_dir("q", pt->....)
> 
> here instead.
> 

Thanks Greg. Will make this change.

> thanks,
> 
> greg k-h
> 

  reply	other threads:[~2021-08-05 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 10:32 [PATCH v11 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta
2021-08-02 10:32 ` [PATCH v11 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA Sanjay R Mehta
2021-08-02 14:37   ` kernel test robot
2021-08-02 10:32 ` [PATCH v11 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource Sanjay R Mehta
2021-08-02 10:32 ` [PATCH v11 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA Sanjay R Mehta
2021-08-05 12:24   ` Greg KH
2021-08-05 13:25     ` Sanjay R Mehta [this message]
2021-08-02 10:36 ` [PATCH v11 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta
2021-08-05  5:40   ` Vinod Koul
2021-08-05  6:18     ` Sanjay R Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d109c82-4c73-6e8e-ee8d-c6287495dc92@amd.com \
    --to=sanmehta@amd.com \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Sanju.Mehta@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --subject='Re: [PATCH v11 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).