[PATCH] vivi driver works only as first device

[PATCH] vivi driver works only as first device

[Gregor Jasny]

From: Gregor Jasny <gjasny@web.de>

When the vivi driver allocates a video device, video_register_device() stores the
allocated device minor inside the vivi structure. But when the device node is opened,
the file minor number is compared to the minor in the device list. So this patch
copies the allocated minor in the device list, too.

Without this patch it is impossible to use the vivi driver mith minors greater than zero. 

Signed-off-by: Gregor Jasny <gjasny@web.de>
---
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index ee73dc7..f4e533a 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@ -1175,6 +1175,9 @@ static int __init vivi_init(void)
 
 	ret = video_register_device(&vivi, VFL_TYPE_GRABBER, video_nr);
 	printk(KERN_INFO "Video Technology Magazine Virtual Video Capture Board (Load status: %d)\n", ret);
+
+	dev->vfd.minor = vivi.minor;
+
 	return ret;
 }
 

Re: [PATCH] vivi driver works only as first device

[Mauro Carvalho Chehab]

Hi Gregor,
Em Qui, 2007-12-06 às 23:06 +0100, Gregor Jasny escreveu:
> From: Gregor Jasny <gjasny@web.de>
> 
> When the vivi driver allocates a video device, video_register_device() stores the
> allocated device minor inside the vivi structure. But when the device node is opened,
> the file minor number is compared to the minor in the device list. So this patch
> copies the allocated minor in the device list, too.

Thanks for the report. Instead of applying your patch, I decided to
better analyze the issue, fixing it with the proper solution. The issue
is that vivi_register changes iminor, but this change were not properly
returned to the driver.

-- 
Cheers,
Mauro

Re: [PATCH] vivi driver works only as first device

[Gregor Jasny]

On Dec 10, 2007 8:08 AM, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> Thanks for the report. Instead of applying your patch, I decided to
> better analyze the issue, fixing it with the proper solution. The issue
> is that vivi_register changes iminor, but this change were not properly
> returned to the driver.

Any chance to push this into 2.6.24?

Gregor

Re: [PATCH] vivi driver works only as first device

[Mauro Carvalho Chehab]

On Sun, 6 Jan 2008 23:47:19 +0100
"Gregor Jasny" <gjasny@googlemail.com> wrote:

> On Dec 10, 2007 8:08 AM, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> > Thanks for the report. Instead of applying your patch, I decided to
> > better analyze the issue, fixing it with the proper solution. The issue
> > is that vivi_register changes iminor, but this change were not properly
> > returned to the driver.
> 
> Any chance to push this into 2.6.24?

I've scheduled this patch for inclusion at 2.6.25-rc.

Cheers,
Mauro