From: Biao Huang <biao.huang@mediatek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<srv_heupstream@mediatek.com>, <macpaul.lin@mediatek.com>,
<angelogioacchino.delregno@collabora.com>, <dkirjanov@suse.de>
Subject: Re: [PATCH net-next v6 5/6] stmmac: dwmac-mediatek: add support for mt8195
Date: Wed, 8 Dec 2021 13:34:23 +0800 [thread overview]
Message-ID: <9d559afc6ae7c5f85bff222aa0c326f3f3e46fcf.camel@mediatek.com> (raw)
In-Reply-To: <20211207200450.093f94a8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Dear Jakub,
Thanks for your comments.
On Tue, 2021-12-07 at 20:04 -0800, Jakub Kicinski wrote:
> On Wed, 8 Dec 2021 11:03:53 +0800 Biao Huang wrote:
> > Add Ethernet support for MediaTek SoCs from the mt8195 family.
> >
> > Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> > Acked-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
>
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:439:3: warning:
> variable 'gtxc_delay_val' is uninitialized when used here [-
> Wuninitialized]
> gtxc_delay_val |= FIELD_PREP(MT8195_DLY_GTXC_ENABLE,
> !!mac_delay->tx_delay);
> ^~~~~~~~~~~~~~
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:369:20: note:
> initialize the variable 'gtxc_delay_val' to silence this warning
> u32 gtxc_delay_val, delay_val = 0, rmii_delay_val = 0;
> ^
> = 0
> 1 warning generated.
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:439:3: warning:
> variable 'gtxc_delay_val' is uninitialized when used here [-
> Wuninitialized]
> gtxc_delay_val |= FIELD_PREP(MT8195_DLY_GTXC_ENABLE,
> !!mac_delay->tx_delay);
> ^~~~~~~~~~~~~~
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:369:20: note:
> initialize the variable 'gtxc_delay_val' to silence this warning
> u32 gtxc_delay_val, delay_val = 0, rmii_delay_val = 0;
> ^
> = 0
I'll fix the uninitialized warning in next send.
next prev parent reply other threads:[~2021-12-08 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 3:03 [PATCH net-next v6 0/6] MediaTek Ethernet Patches on MT8195 Biao Huang
2021-12-08 3:03 ` [PATCH net-next v6 1/6] stmmac: dwmac-mediatek: add platform level clocks management Biao Huang
2021-12-09 10:50 ` AngeloGioacchino Del Regno
2021-12-08 3:03 ` [PATCH net-next v6 2/6] stmmac: dwmac-mediatek: Reuse more common features Biao Huang
2021-12-08 3:03 ` [PATCH net-next v6 3/6] arm64: dts: mt2712: update ethernet device node Biao Huang
2021-12-08 3:03 ` [PATCH net-next v6 4/6] net: dt-bindings: dwmac: Convert mediatek-dwmac to DT schema Biao Huang
2021-12-08 3:03 ` [PATCH net-next v6 5/6] stmmac: dwmac-mediatek: add support for mt8195 Biao Huang
2021-12-08 4:04 ` Jakub Kicinski
2021-12-08 5:34 ` Biao Huang [this message]
2021-12-08 3:03 ` [PATCH net-next v6 6/6] net: dt-bindings: dwmac: " Biao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d559afc6ae7c5f85bff222aa0c326f3f3e46fcf.camel@mediatek.com \
--to=biao.huang@mediatek.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dkirjanov@suse.de \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).