From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B23BC4360F for ; Wed, 3 Apr 2019 13:49:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7EE320830 for ; Wed, 3 Apr 2019 13:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="a+09Q+zu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726419AbfDCNte (ORCPT ); Wed, 3 Apr 2019 09:49:34 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35004 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726206AbfDCNtd (ORCPT ); Wed, 3 Apr 2019 09:49:33 -0400 Received: by mail-pf1-f194.google.com with SMTP id t21so8198032pfe.2 for ; Wed, 03 Apr 2019 06:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=a+09Q+zugRlUHjkyucJBUCWf446/MQuUX5HgeGs3ZuGQQLIWjJL4mBRQrPd8Bx1buN pS4R4TpqP3XhVpa6S7zs10taoPdLsT7v+9IuXra/Uik1YcsijFXT7lR/UJiVHpj8asQt ZKI61os4qE1ceMgeeCWS8eeEqFOYcwVarDSKzOrfLlnJyc5wRdlnXGw37CR8OlhLZqnf yHVyoaWIHJpz8YliG/fKTjFH1niDFOpAo/QavcioqNac4ds3tqnSs5/kTVDh1j1rvHJs S0B+dWgq7An+aJLx8NTQYB7UoUjMFTNUGB972txZpMDJCgnpUlYul4Q6ZsTAr8wNltER O/0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=kjmDhtfixo8daBn5GexOuCOesWYfsMGihSD0O26BcvInE2xu9UWRQgF7s8k0ndiRM2 HMvJTOdgWArxCUSHzdN1RS+OeeL9bikNMJxCc25g3LrJDg4lFQW/WCaucRNlWhVlaDDL DJ8Zw05QWAh0WvZmjwt/fcNUHDD/twnvR2RsStIneXeeVEFUqJkhbCLPDUpKCRQB6tJD uit7aCLy+iCSC376be23+8oM3QXkEXePFd/w8FVasMcedIZGzvcv1mkmKwGw0QlKLIQq klE3iRXBwKQvL5JyxAEXmHCuvtHynG9PBQIJiKIininqkrYSV/gos03RI77QlE1nq0Xr Jvag== X-Gm-Message-State: APjAAAWVvpv4I2yzIjdHHFQxlDcz9EZSBNcIt9+eYjO/1f6Zjc/tznD9 IHbnVqcnJfNF0rCZ+eYkwUcIJQ== X-Google-Smtp-Source: APXvYqzl4pp2LVq+nDJhXTBECl1hQPThxVc/ItK+ZQpXYL1XB54jwn23RYPTMUJAYmiOOJU/yQZx8A== X-Received: by 2002:a62:2687:: with SMTP id m129mr25296327pfm.204.1554299372295; Wed, 03 Apr 2019 06:49:32 -0700 (PDT) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id g2sm22691245pfd.134.2019.04.03.06.49.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 06:49:30 -0700 (PDT) Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere To: Will Deacon , Michael Ellerman Cc: Arnd Bergmann , Andrew Morton , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Catalin Marinas , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Michal Simek , Ralf Baechle , Paul Burton , James Hogan , "James E . J . Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , Rich Felker , "David S . Miller" , Max Filippov , Firoz Khan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20190325143521.34928-1-arnd@arndb.de> <20190325144737.703921-1-arnd@arndb.de> <87tvff24a1.fsf@concordia.ellerman.id.au> <20190403111134.GA7159@fuggles.cambridge.arm.com> From: Jens Axboe Message-ID: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> Date: Wed, 3 Apr 2019 07:49:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/3/19 5:11 AM, Will Deacon wrote: > Hi Michael, > > On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote: >> Arnd Bergmann writes: >>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl >>> index b18abb0c3dae..00f5a63c8d9a 100644 >>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl >>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl >>> @@ -505,3 +505,7 @@ >>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64 >>> 422 32 futex_time64 sys_futex sys_futex >>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval >>> +424 common pidfd_send_signal sys_pidfd_send_signal >>> +425 common io_uring_setup sys_io_uring_setup >>> +426 common io_uring_enter sys_io_uring_enter >>> +427 common io_uring_register sys_io_uring_register >> >> Acked-by: Michael Ellerman (powerpc) >> >> Lightly tested. >> >> The pidfd_test selftest passes. > > That reports pass for me too, although it fails to unshare the pid ns, which I > assume is benign. > >> Ran the io_uring example from fio, which prints lots of: > > How did you invoke that? I had a play with the tests in: It's t/io_uring from the fio repo: git://git.kernel.dk/fio and you just run it ala: # make t/io_uring # t/io_uring /dev/some_device > git://git.kernel.dk/liburing > > but I quickly ran into the kernel oops below. > > Will > > --->8 > > will@autoplooker:~/liburing/test$ ./io_uring_register > RELIMIT_MEMLOCK: 67108864 (67108864) > [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070 > [ 35.478969] Mem abort info: > [ 35.479296] ESR = 0x96000004 > [ 35.479785] Exception class = DABT (current EL), IL = 32 bits > [ 35.480528] SET = 0, FnV = 0 > [ 35.480980] EA = 0, S1PTW = 0 > [ 35.481345] Data abort info: > [ 35.481680] ISV = 0, ISS = 0x00000004 > [ 35.482267] CM = 0, WnR = 0 > [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) > [ 35.483486] [0000000000000070] pgd=0000000000000000 > [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 35.484788] Modules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : ffff000017e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe