From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Kai Huang <kai.huang@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Andi Kleen <ak@linux.intel.com>,
Wander Lairson Costa <wander@redhat.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] x86/tdx: Add Quote generation support
Date: Thu, 5 May 2022 15:38:43 -0700 [thread overview]
Message-ID: <9d869ed2-2b3b-8007-a12d-6d73a54d6a05@linux.intel.com> (raw)
In-Reply-To: <d53696f85ada39a91a3685c61d177c582810772e.camel@intel.com>
On 5/5/22 3:15 PM, Kai Huang wrote:
> On Thu, 2022-05-05 at 13:53 -0700, Sathyanarayanan Kuppuswamy wrote:
>> Hi Kai,
>>
>> On 5/4/22 4:28 PM, Kai Huang wrote:
>>> On Wed, 2022-05-04 at 15:49 -0700, Sathyanarayanan Kuppuswamy wrote:
>>>> --- a/arch/x86/coco/tdx/tdx.c
>>>> +++ b/arch/x86/coco/tdx/tdx.c
>>>> @@ -15,6 +15,7 @@
>>>> #include <asm/idtentry.h>
>>>> #include <asm/irq_regs.h>
>>>> #include <asm/desc.h>
>>>> +#include <asm/io.h>
>>>>
>>>> /* TDX module Call Leaf IDs */
>>>> #define TDX_GET_INFO 1
>>>> @@ -680,8 +681,15 @@ static bool try_accept_one(phys_addr_t *start,
>>>> unsigned long len,
>>>> */
>>>> static bool tdx_enc_status_changed(unsigned long vaddr, int numpages,
>>>> bool enc)
>>>> {
>>>> - phys_addr_t start = __pa(vaddr);
>>>> - phys_addr_t end = __pa(vaddr + numpages * PAGE_SIZE);
>>>> + phys_addr_t start;
>>>> + phys_addr_t end;
>>>> +
>>>> + if (is_vmalloc_addr((void *)vaddr))
>>>> + start = page_to_phys(vmalloc_to_page((void*)vaddr));
>>>> + else
>>>> + start = __pa(vaddr);
>>>> +
>>>> + end = start + numpages * PAGE_SIZE;
>>>>
>>>> if (!enc) {
>>>> /* Set the shared (decrypted) bits: */
>>>
>>> Looks set_memory_decrypted() only works for direct-mapping, so you should not
>>> use this. Instead, you can pass shared bit in 'prot' argument (using
>>> pgprot_decrypted()) when you call vmap(), and explicitly call MapGPA().
>>
>> Is it because of the above change, or you see other direct-mapping
>> dependencies in set_memory_*() functions?
>>
>>
>>
> set_memory_xx() is supposedly only for direct-mapping. Please use my
> suggestion above.
I did not find any other direct-mapping dependency in set_memory_*()
functions other than what I have fixed. If I missed anything, please
let me know.
Also, even if set_memory_*() functions does not support vmalloc'ed
memory, IMO, it is better to add this support to it.
I want to avoid custom solution if it is possible to use generic
function.
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2022-05-05 22:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 18:34 [PATCH v5 0/3] Add TDX Guest Attestation support Kuppuswamy Sathyanarayanan
2022-05-01 18:34 ` [PATCH v5 1/3] x86/tdx: Add TDX Guest attestation interface driver Kuppuswamy Sathyanarayanan
2022-05-02 2:31 ` Kai Huang
2022-05-02 15:52 ` Sathyanarayanan Kuppuswamy
2022-05-02 22:30 ` Kai Huang
2022-05-02 23:17 ` Sathyanarayanan Kuppuswamy
2022-05-02 23:37 ` Kai Huang
2022-05-03 14:38 ` Wander Costa
2022-05-03 15:09 ` Sathyanarayanan Kuppuswamy
2022-05-03 22:08 ` Kai Huang
2022-05-02 12:18 ` Wander Lairson Costa
2022-05-02 16:06 ` Sathyanarayanan Kuppuswamy
2022-05-01 18:34 ` [PATCH v5 2/3] x86/tdx: Add TDX Guest event notify interrupt support Kuppuswamy Sathyanarayanan
2022-05-02 12:44 ` Wander Lairson Costa
2022-05-01 18:35 ` [PATCH v5 3/3] x86/tdx: Add Quote generation support Kuppuswamy Sathyanarayanan
2022-05-02 2:40 ` Kai Huang
2022-05-03 1:27 ` Kirill A. Shutemov
2022-05-03 2:18 ` Kai Huang
2022-05-03 2:39 ` Sathyanarayanan Kuppuswamy
2022-05-03 22:13 ` Kai Huang
2022-05-03 2:45 ` Kirill A. Shutemov
2022-05-03 3:36 ` Kai Huang
2022-05-03 22:24 ` Dave Hansen
2022-05-03 22:28 ` Sathyanarayanan Kuppuswamy
2022-05-03 22:30 ` Sathyanarayanan Kuppuswamy
2022-05-04 22:49 ` Sathyanarayanan Kuppuswamy
2022-05-04 23:28 ` Kai Huang
2022-05-05 20:53 ` Sathyanarayanan Kuppuswamy
2022-05-05 22:15 ` Kai Huang
2022-05-05 22:38 ` Sathyanarayanan Kuppuswamy [this message]
2022-05-05 23:06 ` Dave Hansen
2022-05-06 0:11 ` Kai Huang
2022-05-06 1:55 ` Sathyanarayanan Kuppuswamy
2022-05-07 0:42 ` Kirill A. Shutemov
2022-05-09 3:37 ` Kai Huang
2022-05-09 12:09 ` Kirill A. Shutemov
2022-05-09 14:14 ` Dave Hansen
2022-05-09 15:35 ` Kirill A. Shutemov
2022-05-09 15:43 ` Sathyanarayanan Kuppuswamy
2022-05-09 23:54 ` Kai Huang
2022-05-10 0:17 ` Sathyanarayanan Kuppuswamy
2022-05-10 1:30 ` Kirill A. Shutemov
2022-05-10 1:40 ` Kai Huang
2022-05-10 10:42 ` Kai Huang
2022-05-16 17:39 ` Sathyanarayanan Kuppuswamy
2022-05-06 11:00 ` Kai Huang
2022-05-06 15:47 ` Dave Hansen
2022-05-07 1:00 ` Kirill A. Shutemov
2022-05-05 10:50 ` Kai Huang
2022-05-05 19:03 ` Sathyanarayanan Kuppuswamy
2022-05-05 22:25 ` Kai Huang
2022-05-02 5:01 ` Kai Huang
2022-05-02 16:02 ` Sathyanarayanan Kuppuswamy
2022-05-02 23:02 ` Kai Huang
2022-05-02 13:16 ` Wander Lairson Costa
2022-05-02 16:05 ` Sathyanarayanan Kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d869ed2-2b3b-8007-a12d-6d73a54d6a05@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@gmail.com \
--cc=kai.huang@intel.com \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mingo@redhat.com \
--cc=philip.cox@canonical.com \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).