From: Randy Dunlap <rdunlap@infradead.org>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Josh Triplett" <josh@joshtriplett.org>,
"Steven Rostedt" <rostedt@goodmis.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: next-20200528 - build error in kernel/rcu/refperf.c
Date: Thu, 28 May 2020 21:48:18 -0700 [thread overview]
Message-ID: <9d8b13db-9d77-416d-e283-9ea509ce43d1@infradead.org> (raw)
In-Reply-To: <538911.1590725791@turing-police>
On 5/28/20 9:16 PM, Valdis Klētnieks wrote:
> commit 9088b449814f788d24f35a5840b6b2c2a23cd32a
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date: Mon May 25 17:22:24 2020 -0700
>
> refperf: Provide module parameter to specify number of experiments
>
> changes this line of code (line 389)
>
> - reader_tasks[exp].result_avg = 1000 * process_durations(exp) / ((exp + 1) * loops);
> + result_avg[exp] = 1000 * process_durations(nreaders) / (nreaders * loops);
>
> On a 32-bit ARM make allmodconfig with gcc 8.3, this results in:
>
> ERROR: modpost: "__aeabi_uldivmod" [kernel/rcu/refperf.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:103: __modpost] Error 1
>
> I admit not understanding why the original line of code worked and the new one doesn't.
> Maybe gcc is smarter/dumber about the ranges of 'exp' and 'nreaders' than we thought?
>
Paul has already responded: (unfortunately)
"So I am restricting to 64BIT for the time being. Yeah, I know, lazy of
me. ;-)"
https://lore.kernel.org/lkml/20200528180855.GP2869@paulmck-ThinkPad-P72/
--
~Randy
next prev parent reply other threads:[~2020-05-29 4:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 4:16 next-20200528 - build error in kernel/rcu/refperf.c Valdis Klētnieks
2020-05-29 4:48 ` Randy Dunlap [this message]
2020-05-29 5:24 ` Valdis Klētnieks
2020-05-29 14:02 ` Paul E. McKenney
2020-05-29 13:55 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8b13db-9d77-416d-e283-9ea509ce43d1@infradead.org \
--to=rdunlap@infradead.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).