From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-doc@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Dave Jones <davej@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
"David S . Miller" <davem@davemloft.net>,
Pavel Begunkov <asml.silence@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/core: Remove comment quote for __dev_queue_xmit()
Date: Wed, 4 May 2022 11:28:51 +0700 [thread overview]
Message-ID: <9d8b436a-5d8d-2a53-a2a1-5fbab987e41b@gmail.com> (raw)
In-Reply-To: <20220503180341.36dcbb07@kernel.org>
On 5/4/22 08:03, Jakub Kicinski wrote:
> On Tue, 3 May 2022 14:29:49 +0700 Bagas Sanjaya wrote:
>> - * -----------------------------------------------------------------------------------
>> - * I notice this method can also return errors from the queue disciplines,
>> - * including NET_XMIT_DROP, which is a positive value. So, errors can also
>> - * be positive.
>> - *
>> - * Regardless of the return value, the skb is consumed, so it is currently
>> - * difficult to retry a send to this method. (You can bump the ref count
>> - * before sending to hold a reference for retry if you are careful.)
>> - *
>> - * When calling this method, interrupts MUST be enabled. This is because
>> - * the BH enable code must have IRQs enabled so that it will not deadlock.
>> - * --BLG
>> + * This method can also return positive errno code from the queue
>> + * disciplines (including NET_XMIT_DROP).
>> + *
>> + * Note that regardless of the return value, the skb is consumed
>> + * anyway, so it is currently difficult to retry sending to this
>> + * method.
>
> Why drop almost half of the comment if the problem is just the ----
> banner?
I can't think of preserving delineation between actual documentation
and the quote without messing up kernel-doc.
Actually the "--BLG" signature is the culprit.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-05-04 4:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:29 [PATCH net-next] net/core: Remove comment quote for __dev_queue_xmit() Bagas Sanjaya
2022-05-04 1:03 ` Jakub Kicinski
2022-05-04 4:28 ` Bagas Sanjaya [this message]
2022-05-04 13:43 ` Akira Yokosawa
2022-05-04 14:37 ` Jakub Kicinski
2022-05-05 0:30 ` Akira Yokosawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8b436a-5d8d-2a53-a2a1-5fbab987e41b@gmail.com \
--to=bagasdotme@gmail.com \
--cc=asml.silence@gmail.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).