From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbdFZVkF (ORCPT ); Mon, 26 Jun 2017 17:40:05 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33046 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbdFZVju (ORCPT ); Mon, 26 Jun 2017 17:39:50 -0400 Subject: Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer To: Alexandre Belloni , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Brian Norris , Markus Mayer , Alessandro Zummo , Rob Herring , Mark Rutland , Gregory Fong , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20170615195904.12653-1-f.fainelli@gmail.com> <20170615195904.12653-3-f.fainelli@gmail.com> <20170624185942.vq656pjxbqnqdhll@piout.net> <35c43786-ee58-130c-2ecd-5577197bd5aa@gmail.com> <20170626213534.jur6rggwbzhk6r4t@piout.net> From: Florian Fainelli Message-ID: <9d8f0475-5a52-c7dc-2f39-1b5cbad608e9@gmail.com> Date: Mon, 26 Jun 2017 14:39:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170626213534.jur6rggwbzhk6r4t@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2017 02:35 PM, Alexandre Belloni wrote: > On 26/06/2017 at 10:15:46 -0700, Florian Fainelli wrote: >>> This is not needed since d68778b80dd7 >> >> Great, I will take that out. >> >> Do you care whether some dev_dbg() prints are left in the driver or >> should I remove those in v2? >> > > It could have stayed but it seems you removed it from v2. > > I'll applay that but it is ok if you change your mind. No, I think they don't really belong in the driver anymore, thanks! -- Florian