From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB09C43603 for ; Wed, 11 Dec 2019 09:51:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D991214AF for ; Wed, 11 Dec 2019 09:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728628AbfLKJvr (ORCPT ); Wed, 11 Dec 2019 04:51:47 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:56051 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727493AbfLKJvr (ORCPT ); Wed, 11 Dec 2019 04:51:47 -0500 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ieyek-00028x-1P; Wed, 11 Dec 2019 10:51:42 +0100 Message-ID: <9d8fd7d89e035c41a3be7d5a5fa2e370b32910f1.camel@pengutronix.de> Subject: Re: [PATCH 15/15] reset: reset-scmi: Match scmi device by both name and protocol id From: Philipp Zabel To: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Cristian Marussi Date: Wed, 11 Dec 2019 10:51:41 +0100 In-Reply-To: <20191210145345.11616-16-sudeep.holla@arm.com> References: <20191210145345.11616-1-sudeep.holla@arm.com> <20191210145345.11616-16-sudeep.holla@arm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, On Tue, 2019-12-10 at 14:53 +0000, Sudeep Holla wrote: > The scmi bus now has support to match the driver with devices not only > based on their protocol id but also based on their device name if one is > available. This was added to cater the need to support multiple devices > and drivers for the same protocol. > > Let us add the name "reset" to scmi_device_id table in the driver so > that in matches only with device with the same name and protocol id > SCMI_PROTOCOL_RESET. > > Cc: Philipp Zabel > Signed-off-by: Sudeep Holla > --- > drivers/reset/reset-scmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c > index b46df80ec6c3..8d3a858e3b19 100644 > --- a/drivers/reset/reset-scmi.c > +++ b/drivers/reset/reset-scmi.c > @@ -108,7 +108,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) > } > > static const struct scmi_device_id scmi_id_table[] = { > - { SCMI_PROTOCOL_RESET }, > + { SCMI_PROTOCOL_RESET, "reset" }, > { }, > }; > MODULE_DEVICE_TABLE(scmi, scmi_id_table); > -- > 2.17.1 I can't speak to the correctness of this approach, but in case the rest of the series passes review, this patch is Acked-by: Philipp Zabel to be merged together with the other patches. regards Philipp