From: asutoshd@codeaurora.org
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
cang@codeaurora.org, alim.akhtar@samsung.com,
avri.altman@wdc.com, bvanassche@acm.org
Subject: Re: [PATCH v3 5/5] scsi: ufs: fix clkgating on/off correctly
Date: Mon, 26 Oct 2020 11:33:11 -0700 [thread overview]
Message-ID: <9dbeb21b7a899d742670a243a9ffad7d@codeaurora.org> (raw)
In-Reply-To: <20201024150646.1790529-6-jaegeuk@kernel.org>
On 2020-10-24 08:06, Jaegeuk Kim wrote:
> The below call stack prevents clk_gating at every IO completion.
> We can remove the condition, ufshcd_any_tag_in_use(), since
> clkgating_work
> will check it again.
>
> ufshcd_complete_requests(struct ufs_hba *hba)
> ufshcd_transfer_req_compl()
> __ufshcd_transfer_req_compl()
> __ufshcd_release(hba)
> if (ufshcd_any_tag_in_use() == 1)
> return;
> ufshcd_tmc_handler(hba);
> blk_mq_tagset_busy_iter();
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index c94610cbecae..38043c6b8d5f 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1746,7 +1746,7 @@ static void __ufshcd_release(struct ufs_hba *hba)
>
> if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended ||
> hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL ||
> - ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks ||
> + hba->outstanding_tasks ||
> hba->active_uic_cmd || hba->uic_async_done)
> return;
prev parent reply other threads:[~2020-10-26 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 15:06 [UFS v3] UFS fixes Jaegeuk Kim
2020-10-24 15:06 ` [PATCH v3 1/5] scsi: ufs: atomic update for clkgating_enable Jaegeuk Kim
2020-10-26 3:28 ` Can Guo
2020-10-26 6:13 ` Jaegeuk Kim
2020-10-26 6:43 ` Can Guo
2020-10-26 19:48 ` Jaegeuk Kim
2020-10-27 2:44 ` Can Guo
2020-10-24 15:06 ` [PATCH v3 2/5] scsi: ufs: clear UAC for FFU and RPMB LUNs Jaegeuk Kim
2020-10-26 18:25 ` asutoshd
2020-10-26 19:43 ` Jaegeuk Kim
2020-10-27 17:48 ` kernel test robot
2020-10-24 15:06 ` [PATCH v3 3/5] scsi: ufs: use WQ_HIGHPRI for gating work Jaegeuk Kim
2020-10-26 18:27 ` asutoshd
2020-10-24 15:06 ` [PATCH v3 4/5] scsi: add more contexts in the ufs tracepoints Jaegeuk Kim
2020-10-24 15:06 ` [PATCH v3 5/5] scsi: ufs: fix clkgating on/off correctly Jaegeuk Kim
2020-10-26 18:33 ` asutoshd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbeb21b7a899d742670a243a9ffad7d@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).