From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753964AbcIIQMa (ORCPT ); Fri, 9 Sep 2016 12:12:30 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:42064 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753623AbcIIQM0 (ORCPT ); Fri, 9 Sep 2016 12:12:26 -0400 Subject: Re: [PATCH 3/5] nbd: use flags instead of bool To: Joe Perches , Josef Bacik , , , , , References: <1473369130-22986-1-git-send-email-jbacik@fb.com> <1473369130-22986-4-git-send-email-jbacik@fb.com> <1473384038.13672.23.camel@perches.com> <1473437068.13672.41.camel@perches.com> From: Jens Axboe Message-ID: <9ddc6c54-72cd-b3d4-d7f3-f96dc33164fc@fb.com> Date: Fri, 9 Sep 2016 10:11:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473437068.13672.41.camel@perches.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR19CA0014.namprd19.prod.outlook.com (10.164.243.152) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-Office365-Filtering-Correlation-Id: 9e93244b-3993-48a0-10b0-08d3d8cc0a58 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;2:DksBYWa+ySu8SzJnHwpKwZK+BEwl9L3G7YkkGz1v8dAhw+QWVhoF9rZ/0e5K8rWlxGvhqdhZVaaoXoIT6nAbTEQu9rjSHQmmlcXHxo7x34fY+vQElIz2nAzy42/k8mD880og1MIiAsxx7z9PgcaEVhimQCxtD3IMbmhUGhHh1eL5XF8RsmEnoLQ/ucPeOicG;3:wacCOUQrnmiWaDrx9KKGuXugTwJqonKYx72IjJH9hOS7i8SHDOL9p3qCYET8FFk4s4UTqFJDmGoAba+LZ2jPcTwp3J1Ny4jlG028AIPtBMlsfLt1cuL+EQsgpn+o79WK;25:dqv3URGurFxZ16swnHrJH7lva4JAt4eOf0Md7hTVDB2ZeXeX7AOQhmMO3TJEzQTQod1/GeTiSzMha3JjTFTuAGGIRP6Vym6u8HzqJv/1ljuBb8RbGMw38+CKCgrdHsi4Ks7oum3imz69QNAoZvG+kmeUf/lTBa6xjQtFB16uxZ6vOfteWFmI1FsQrqxQwoLDuSyxvuE9jo8KiQWnKW+NlSBTPe6CzMT7op0UeR3Ap2i39cRsGNoSReKt2Ssg+Ku6a+6G7w+B8xaJApqRz46AJDG+hGLPvnUZR8cOMbjkXrsbObZisB4mhkR15KMhXZgNqJm+TE4pgvx8lyXZj36lB5npv6W0PtFPWchJlzi24wywGmIAE8PquL5nsr/tOO+TVuUBreNwQmrP2pBiEhzV1A==;31:D/fOwf2Rw7HvXnrrEU/c+L93YEBpZiZMCc6z7EoDMgU90YUn0Y7UZTZjB/XDzSsEFyrZsJoxYZ+DQvJISnlbNTgr15sJh8lKGfilnQU+minC9vu2Ef+Ee9Mtck3mq0SmVlAN+IgUyT+NYNajW6yFM25O4viMOakUquK9WUgODfbNWKvI9lKAF3RnpmTkhuVVlVoO4SvDyeaHClODmMdeHqm8IW+CGu0f8veF5d8/9ys= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:yEYPyNllUNKB1r9pp4+1AiJ5UlPoIaa1MEIArEAgqhnSWl2bBhXN/PAby75ZYm7S5VaZTCHzxTVh0JrRtC130g4ZAA1UZ7TVHrIBdsQeNhENeOeehu+GZ6iHYTWIPRIfeeib8qu1xYE8esp/Ohqu0DEmEwd+hwuipEsdzLwp57o=;4:2C4vkEd+YeGNJvmXNljsEWbC8OodIrfhwgJfXOxAXVIr2z3ug4m/luuyKlptPi6bEHjD/XcNMdqyKcKcKaP6t61MtUS67n3+L/Tdh5Q2Ps+S7VmGqxA8BAQuB+CO2LnCd81Nj2ys1htN7Fr+92g9cdXn3gZydajseNQCM0ffM4fN/Nt7c3No2BvvWm94Zs+qm8qRvCn2KYCUJOGl5xuT70j8FqXZWZAMLkpY4YoT7WjTLktrgYyB3CTjNQFn+Rn95TH4sYKBp3eg3/PMGhugGfe+TCfoH4EoU6bLJO7LAUaB+PDel9wMKvu25PVNR3RxIogt54ujf1DDaIHwVx7TWYHP8Ldm4wMmmawdrc1bVYCy+v5pp54bw+x3+ia2lKHdWNn0hhOK6VmPIFAtuVbsVQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Forefront-PRVS: 00603B7EEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(377454003)(377424004)(24454002)(189002)(23746002)(101416001)(92566002)(189998001)(7736002)(2906002)(7846002)(2950100001)(64126003)(31686004)(586003)(6116002)(2201001)(3846002)(97736004)(81156014)(230700001)(33646002)(42186005)(81166006)(86362001)(66066001)(50986999)(305945005)(5001770100001)(76176999)(93886004)(105586002)(65806001)(68736007)(8676002)(83506001)(65956001)(5660300001)(31696002)(54356999)(117156001)(4001350100001)(107886002)(36756003)(77096005)(65826007)(47776003)(106356001)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1187;23:vFqhXqJhzEd00v88yiNkatBxG7hmwRk2JSqK6?= =?Windows-1252?Q?0G4UOO3/DUcClxJ4UlSPCJDLyQrf7RtXsClYvbAx9i2mrT4SSx4LBTHD?= =?Windows-1252?Q?9Vs8YUt+hSOI2kVrW/VVFG2jGe81HLV1CIC6XgMePafq8Z+OiuR5FG/A?= =?Windows-1252?Q?E4jWDLOf8IMV/sVpQyBBwJ00RLSbBEt+7aTAUIqECeC73uTyMf+egWt1?= =?Windows-1252?Q?sHNHRnz9k429CHekifimd3VeIBBiKyhwRhJoeDyHimhwJhzKA7M6JpOU?= =?Windows-1252?Q?UD2j1J8b4XnsN0XmB2+leFABr+H/lbvPQ82wpHVrCLAtLuFQBVOBV6ft?= =?Windows-1252?Q?TUf96mmKgY2RzACDSSQJlqJvz1WZT3cGU0Ufu54yMLKwHe6cyPrgo4ge?= =?Windows-1252?Q?NymLReJlnkA/w34dX9BZZZ6N08hJ711o3Ch/7yGTfmaR3x5Sfc70Tq/f?= =?Windows-1252?Q?4m1vpwCQl4/R1j0uc3mUu5IPZEgCUcDE1q6bOyz09i67lO+5ZLRY7m5j?= =?Windows-1252?Q?z0TK5hWx2dMJEYCW6FAeGtYLhIkM8Xff/vTE+GPpQR3hfb7s0A97Izvb?= =?Windows-1252?Q?bHCFot9fNUctp16kWo98cQlGbHXCmcbGr2Ht5RgMOnFJDWY6klnSZvDI?= =?Windows-1252?Q?xS8AQEMCpuxhr0Db6Die5sT6Gx+wcqwENQI0UWQGb0NItGI2uKEhFDQN?= =?Windows-1252?Q?FrV7AA6WC1naE9CWjVgz6kpEsy79n/Wzf7WB2BjTbu8dPJsRT1zqsnYA?= =?Windows-1252?Q?qKIp9HXozryyvoOaWNhJ8zrGfT3D1aCn/4nSau2VZePiS9oPZ/ndyY8Q?= =?Windows-1252?Q?p3syfPfl3fKN1rcADam3CRVbhX+mD3+MGZtbaLrMStIsVlB70HpxB3jd?= =?Windows-1252?Q?zbHsrmrj2L8BEfBNAnujsGSCGHyFw/F7G8iV1AqTqXuquIUViChmx16e?= =?Windows-1252?Q?ecH2mShzGXlJkTCTNYSoGN7d/9VWbjhjiMa9vmaG9OWGHj4c5DMebBIQ?= =?Windows-1252?Q?39ykI9dU4EOaEXz4QkrNOwSm1t4+LzHWlqSVyiydPnrJ24z8thsUnG5P?= =?Windows-1252?Q?v4R07QoyBJH9oEhNJP/uoZOp4+Q6UgBwtEgX+uq8uDodk38Kd0sS3kyF?= =?Windows-1252?Q?WIoReUVOtJ/nQqTm8qbeJaIxkJetEjqr50ZthmNULxuB8fvpn7F14td6?= =?Windows-1252?Q?AWsBDME+g/BvWB6LD5LupJGUxVMDOSElIacHxIm7DB1a8lMTsyEITYiW?= =?Windows-1252?Q?NcQZq8WoHPIL8EptLIyXNkJNy7tFAH21h0AvWwyM7ByY8/EpD1rKJYKh?= =?Windows-1252?Q?DK9q/YGvLMR7ly6lVjnXHl0w+LnAyX9LIEkj+GYlKGnw3rGAAQMl4ECX?= =?Windows-1252?Q?96+tKFUBnZZzno1jR7b9o5C77QW23oB2q+m9wHS17oRa+/fJhQKCS6MR?= =?Windows-1252?Q?QnfetF6O8iUEWtgJgTl?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;6:5mqdMeBF07PpWezSmvOxcwr9yw32HyFuGYmcksmQTXJO6IjftLWo7WS5h/cNpNY+InzpTuWsoL2I6zpD1O2q4q0tGwSV31Cqg2LB8+3pDYYSNq1K7XtNZTv8jzvJdo7WmhmcXPa11mxrLHXFB/Lbv7nSSl61/HtClknc4fC25c0WTeXUIyB2n9ZN5RqTebm/TIyavrBqChr+1kuHq6yCbQS7/4tnbaUdJhKxqsfLT3PEw2L549XUR3vFFrBp7o20+8g/PNukCvMn6GjnD5c9rnQWJuwuf8eBT16AriVKfoU=;5:g/aUqMffbmUmy4TyKWzCkilUGoRMhb+r0VrF6Kkm8D9aH7mjGKOxZRx1aX2nOS9ElRee8M5S5vTQLC8Ra0ZFhfqilHTh3sd7qJ8tnqAKVz5uOaqihiUSIAN5DprI+XdbPPukncZ0WLJvIBaDOsOrRA==;24:pFnyUBvvd8Gz4qe3XiCd8g/hEDSF6GbJK6WKi5xY+YV9F07KY+YdFdpK5ClkWrOt+GjsITMrly+3xK4RtzBHva5akTvQwb5FqWTO+e83RXA=;7:Rn/zradrG7AUtA26cS5F7FIxrFCV2tqivRqMd1EDs+lcwlK4op8q3EbCvH0MrR+gjpHEbSasknLziSJix6IeSPUVfrZVS+xWMniCSfhsrim/JTPOQURe89haeiaeuxGPmcY75SFISOVpf/8/pBiMh0qrfrl0cz+w7YiaV+nKnYjtR4x+LK6QW43u99T2kv2O5On6wygj50MryUOp2TmmpKzEYdwEdmvyzXSXa3MIHM257Y9Rnjv2YNrIJl6WwKVL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:CukaVo4tmBxEjh17cQSmq1j60dkkSyz2N5PxQKzZ6Spm6CIS4jMvT8Uq/7zeDEMzLRi38HSdTomLhNq4kc0K0Y6WUO+sB56BiCWL1RxTUA3LV8kp7k/cjCRl1nUy40gV35gOryFR55wZza6UydvIrl1Do98qZ7q7muV2aHRMRs4= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 16:12:04.0237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-09_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2016 10:04 AM, Joe Perches wrote: > On Fri, 2016-09-09 at 07:55 -0600, Jens Axboe wrote: >> On 09/08/2016 07:20 PM, Joe Perches wrote: >>> On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote: >>>> In preparation for some future changes, change a few of the state bools over to >>>> normal bits to set/clear properly. >>> [] >>>> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c >>> [] >>>> @@ -41,8 +41,12 @@ >>>> >>>> #include >>>> >>>> +#define NBD_TIMEDOUT 0 >>>> +#define NBD_DISCONNECT_REQUESTED 1 >>>> + >>>> struct nbd_device { >>>> u32 flags; >>> + unsigned long runtime_flags; >>> Better to use DECLARE_BITMAP > >> It's a few flags, we know it fits in a long. There's no point to using >> anything but that, and set/test/clear_bit(). > > It lets the reader know how it's used. The variable is called 'runtime_flags' - if that doesn't already tell the reader how it's used, then I'd suggest the reader go read something else. I'm all for using established APIs where it makes sense. Declaring a bitmap for a few fields isn't that. -- Jens Axboe