From: rjliao@codeaurora.org
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
johan.hedberg@gmail.com, marcel@holtmann.org, mka@chromium.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.
Date: Thu, 07 Mar 2019 14:52:49 +0800 [thread overview]
Message-ID: <9df1c9cbbe655d4aca9464cf7ca69900@codeaurora.org> (raw)
In-Reply-To: <a22894cea091ee9945af9c22d6e42051@codeaurora.org>
在 2019-03-07 14:49,Balakrishna Godavarthi 写道:
> Hi Stepen,
>
> On 2019-03-07 04:03, Stephen Boyd wrote:
>> Quoting Balakrishna Godavarthi (2019-03-06 08:21:13)
>>> This patch enables enough time to ROME controller to bootup
>>> after we bring the enable ping out of reset.
>>>
>>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>>> ---
>>
>> Any Fixes tag? And maybe some more explanation or background on where
>> 150 ms sleep comes from would be useful. Was it determined
>> experimentally or did it come from a datasheet somewhere? Does the
>> time
>> differ between boards?
>>
> [Bala]: this was observed in our stress testing and even the CHIP
> firmware team
> confirmed that BT chip required at least 150 ms to boot up.
>
> @Rocky to confirm my statement.
>
>>> drivers/bluetooth/hci_qca.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/bluetooth/hci_qca.c
>>> b/drivers/bluetooth/hci_qca.c
>>> index 237aea34b69f..1953b13511e7 100644
>>> --- a/drivers/bluetooth/hci_qca.c
>>> +++ b/drivers/bluetooth/hci_qca.c
>>> @@ -508,6 +508,8 @@ static int qca_open(struct hci_uart *hu)
>>> qcadev = serdev_device_get_drvdata(hu->serdev);
>>> if (qcadev->btsoc_type != QCA_WCN3990) {
>>> gpiod_set_value_cansleep(qcadev->bt_en, 1);
>>> + /* Controller needs time to bootup. */
>>> + msleep(150);
>>> } else {
>>> hu->init_speed = qcadev->init_speed;
>>> hu->oper_speed = qcadev->oper_speed;
Yes,ROME firmware needs 150ms to boot up after toggle the BT_EN pin.
next prev parent reply other threads:[~2019-03-07 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 16:21 [PATCH v1] Bluetooth: hci_qca: Give enough time to ROME controller to bootup Balakrishna Godavarthi
2019-03-06 22:33 ` Stephen Boyd
2019-03-07 6:49 ` Balakrishna Godavarthi
2019-03-07 6:52 ` rjliao [this message]
2019-03-13 9:45 ` rjliao
2019-03-19 0:49 ` Nicolas Boichat
2019-03-19 2:35 ` Claire Chang
2019-03-08 5:15 ` rjliao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9df1c9cbbe655d4aca9464cf7ca69900@codeaurora.org \
--to=rjliao@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).