From: Zhang Rui <rui.zhang@intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
daniel.lezcano@linaro.org, rjw@rjwysocki.net,
viresh.kumar@linaro.org, lenb@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thermal: intel: Allow processing of HWP interrupt
Date: Fri, 20 Aug 2021 11:35:25 +0800 [thread overview]
Message-ID: <9df6459a7b00ae59b12070a4b1a311c4a29f2321.camel@intel.com> (raw)
In-Reply-To: <20210820024006.2347720-1-srinivas.pandruvada@linux.intel.com>
On Thu, 2021-08-19 at 19:40 -0700, Srinivas Pandruvada wrote:
> Add a weak function to process HWP (Hardware P-states) notifications
> and
> move updating HWP_STATUS MSR to this function.
>
> This allows HWP interrupts to be processed by the intel_pstate driver
> in
> HWP mode by overriding the implementation.
>
> Signed-off-by: Srinivas Pandruvada <
> srinivas.pandruvada@linux.intel.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
thanks,
rui
> ---
> drivers/thermal/intel/therm_throt.c | 7 ++++++-
> drivers/thermal/intel/thermal_interrupt.h | 3 +++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/therm_throt.c
> b/drivers/thermal/intel/therm_throt.c
> index 99abdc03c44c..dab7e8fb1059 100644
> --- a/drivers/thermal/intel/therm_throt.c
> +++ b/drivers/thermal/intel/therm_throt.c
> @@ -569,13 +569,18 @@ static void notify_thresholds(__u64 msr_val)
> platform_thermal_notify(msr_val);
> }
>
> +void __weak notify_hwp_interrupt(void)
> +{
> + wrmsrl_safe(MSR_HWP_STATUS, 0);
> +}
> +
> /* Thermal transition interrupt handler */
> void intel_thermal_interrupt(void)
> {
> __u64 msr_val;
>
> if (static_cpu_has(X86_FEATURE_HWP))
> - wrmsrl_safe(MSR_HWP_STATUS, 0);
> + notify_hwp_interrupt();
>
> rdmsrl(MSR_IA32_THERM_STATUS, msr_val);
>
> diff --git a/drivers/thermal/intel/thermal_interrupt.h
> b/drivers/thermal/intel/thermal_interrupt.h
> index 53f427bb58dc..01e7bed2ffc7 100644
> --- a/drivers/thermal/intel/thermal_interrupt.h
> +++ b/drivers/thermal/intel/thermal_interrupt.h
> @@ -12,4 +12,7 @@ extern int (*platform_thermal_notify)(__u64
> msr_val);
> * callback has rate control */
> extern bool (*platform_thermal_package_rate_control)(void);
>
> +/* Handle HWP interrupt */
> +extern void notify_hwp_interrupt(void);
> +
> #endif /* _INTEL_THERMAL_INTERRUPT_H */
prev parent reply other threads:[~2021-08-20 3:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 2:40 [PATCH 1/2] thermal: intel: Allow processing of HWP interrupt Srinivas Pandruvada
2021-08-20 2:40 ` [PATCH 2/2] cpufreq: intel_pstate: Process HWP Guaranteed change notification Srinivas Pandruvada
2021-08-20 13:10 ` Daniel Lezcano
2021-08-25 18:11 ` Rafael J. Wysocki
[not found] ` <00450b0a9efbfde513ea8b445d31657ce5ac2f37.camel@mengyan1223.wang>
2021-09-08 1:54 ` Srinivas Pandruvada
2021-09-08 5:45 ` Xi Ruoyao
2021-08-20 3:35 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9df6459a7b00ae59b12070a4b1a311c4a29f2321.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).