From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Open code shared_msr_update() in its only caller
Date: Sat, 23 Nov 2019 11:29:49 +0100 [thread overview]
Message-ID: <9e0038a3-dd57-353f-f176-edea48491174@redhat.com> (raw)
In-Reply-To: <20191122200450.26239-1-sean.j.christopherson@intel.com>
On 22/11/19 21:04, Sean Christopherson wrote:
> Fold shared_msr_update() into its sole user to eliminate its pointless
> bounds check, its godawful printk, its misleading comment (it's called
> under a global lock), and its woefully inaccurate name.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> arch/x86/kvm/x86.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index a256e09f321a..35b571c769bd 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -262,23 +262,6 @@ static void kvm_on_user_return(struct user_return_notifier *urn)
> }
> }
>
> -static void shared_msr_update(unsigned slot, u32 msr)
> -{
> - u64 value;
> - unsigned int cpu = smp_processor_id();
> - struct kvm_shared_msrs *smsr = per_cpu_ptr(shared_msrs, cpu);
> -
> - /* only read, and nobody should modify it at this time,
> - * so don't need lock */
> - if (slot >= shared_msrs_global.nr) {
> - printk(KERN_ERR "kvm: invalid MSR slot!");
> - return;
> - }
> - rdmsrl_safe(msr, &value);
> - smsr->values[slot].host = value;
> - smsr->values[slot].curr = value;
> -}
> -
> void kvm_define_shared_msr(unsigned slot, u32 msr)
> {
> BUG_ON(slot >= KVM_NR_SHARED_MSRS);
> @@ -290,10 +273,16 @@ EXPORT_SYMBOL_GPL(kvm_define_shared_msr);
>
> static void kvm_shared_msr_cpu_online(void)
> {
> - unsigned i;
> + unsigned int cpu = smp_processor_id();
> + struct kvm_shared_msrs *smsr = per_cpu_ptr(shared_msrs, cpu);
> + u64 value;
> + int i;
>
> - for (i = 0; i < shared_msrs_global.nr; ++i)
> - shared_msr_update(i, shared_msrs_global.msrs[i]);
> + for (i = 0; i < shared_msrs_global.nr; ++i) {
> + rdmsrl_safe(shared_msrs_global.msrs[i], &value);
> + smsr->values[i].host = value;
> + smsr->values[i].curr = value;
> + }
> }
>
> int kvm_set_shared_msr(unsigned slot, u64 value, u64 mask)
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2019-11-23 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 20:04 [PATCH] KVM: x86: Open code shared_msr_update() in its only caller Sean Christopherson
2019-11-23 10:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0038a3-dd57-353f-f176-edea48491174@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).