From: Oscar Salvador <osalvador@suse.de>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED
Date: Mon, 07 Dec 2020 08:24:54 +0100 [thread overview]
Message-ID: <9e15f4980654717f52733c56c33a3bdd@suse.de> (raw)
In-Reply-To: <20201207023429.GA8986@hori.linux.bs1.fc.nec.co.jp>
On 2020-12-07 03:34, HORIGUCHI NAOYA wrote:
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index 869ece2a1de2..ba861169c9ae 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -1269,6 +1269,12 @@ static int memory_failure_dev_pagemap(unsigned
>> long pfn, int flags,
>> if (!cookie)
>> goto out;
>>
>> + if (flags & MF_COUNT_INCREASED)
>> + /*
>> + * Drop the extra refcount in case we come from madvise().
>> + */
>> + put_page(page);
>> +
>
> Should this if-block come before dax_lock_page() block?
Yeah, it should go first thing since as you noticed we kept the refcount
if we fail.
Saturday brain... I will fix it.
Thanks Naoya
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2020-12-07 7:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 10:57 [PATCH 0/7] HWPoison: Refactor get page interface Oscar Salvador
2020-11-19 10:57 ` [PATCH 1/7] mm,hwpoison: Refactor get_any_page Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:54 ` Vlastimil Babka
2020-11-19 10:57 ` [PATCH 2/7] mm,hwpoison: Drop pfn parameter Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:55 ` Vlastimil Babka
2020-11-19 10:57 ` [PATCH 3/7] mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED Oscar Salvador
2020-11-25 18:20 ` Vlastimil Babka
2020-12-01 11:35 ` Oscar Salvador
2020-12-04 17:25 ` Vlastimil Babka
2020-12-05 15:34 ` Oscar Salvador
2020-12-07 2:34 ` HORIGUCHI NAOYA(堀口 直也)
2020-12-07 7:24 ` Oscar Salvador [this message]
2020-11-19 10:57 ` [PATCH 4/7] mm,hwpoison: remove MF_COUNT_INCREASED Oscar Salvador
2020-11-19 10:57 ` [PATCH 5/7] mm,hwpoison: remove flag argument from soft offline functions Oscar Salvador
2020-11-19 10:57 ` [PATCH 6/7] mm,hwpoison: Disable pcplists before grabbing a refcount Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-26 13:45 ` Vlastimil Babka
2020-11-28 0:51 ` Andrew Morton
2020-11-19 10:57 ` [PATCH 7/7] mm,hwpoison: Remove drain_all_pages from shake_page Oscar Salvador
2020-11-20 1:33 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-26 13:52 ` Vlastimil Babka
2020-11-27 7:20 ` Oscar Salvador
2020-12-02 13:34 ` [PATCH 0/7] HWPoison: Refactor get page interface Qian Cai
2020-12-02 13:41 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e15f4980654717f52733c56c33a3bdd@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=naoya.horiguchi@nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).