From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/16] media: i2c: max9286: Rename reverse_channel_mv
Date: Thu, 18 Feb 2021 15:06:01 +0000 [thread overview]
Message-ID: <9e1cca71-e0f0-4d66-d3f5-268760c53eec@ideasonboard.com> (raw)
In-Reply-To: <20210216174146.106639-11-jacopo+renesas@jmondi.org>
Hi Jacopo,
On 16/02/2021 17:41, Jacopo Mondi wrote:
> Rename the reverse_channel_mv variable to init_rev_chan_mv as
> the next patches will cache the reverse channel amplitude in
> a new driver variable.
>
I've been trying to figure out if we really do need two variables to
store this now, but I can't see an easy way to factor out the
initialisation value, and I like the idea of caching the current stored
value.
So
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/media/i2c/max9286.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 1d9951215868..1f14cd817fbf 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -163,7 +163,7 @@ struct max9286_priv {
> unsigned int mux_channel;
> bool mux_open;
>
> - u32 reverse_channel_mv;
> + u32 init_rev_chan_mv;
>
> struct v4l2_ctrl_handler ctrls;
> struct v4l2_ctrl *pixelrate;
> @@ -563,7 +563,7 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
> * - Disable auto-ack as communication on the control channel are now
> * stable.
> */
> - if (priv->reverse_channel_mv < 170)
> + if (priv->init_rev_chan_mv < 170)
> max9286_reverse_channel_setup(priv, 170);
> max9286_check_config_link(priv, priv->source_mask);
>
> @@ -971,7 +971,7 @@ static int max9286_setup(struct max9286_priv *priv)
> * only. This should be disabled after the mux is initialised.
> */
> max9286_configure_i2c(priv, true);
> - max9286_reverse_channel_setup(priv, priv->reverse_channel_mv);
> + max9286_reverse_channel_setup(priv, priv->init_rev_chan_mv);
>
> /*
> * Enable GMSL links, mask unused ones and autodetect link
> @@ -1236,9 +1236,9 @@ static int max9286_parse_dt(struct max9286_priv *priv)
> if (of_property_read_u32(dev->of_node,
> "maxim,reverse-channel-microvolt",
> &reverse_channel_microvolt))
> - priv->reverse_channel_mv = 170;
> + priv->init_rev_chan_mv = 170;
> else
> - priv->reverse_channel_mv = reverse_channel_microvolt / 1000U;
> + priv->init_rev_chan_mv = reverse_channel_microvolt / 1000U;
>
> priv->route_mask = priv->source_mask;
>
>
next prev parent reply other threads:[~2021-02-18 17:54 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 17:41 [PATCH 00/16] media: i2c: GMSL reliability improvements Jacopo Mondi
2021-02-16 17:41 ` [PATCH 01/16] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-02-17 12:55 ` Kieran Bingham
2021-02-22 0:49 ` Laurent Pinchart
2021-02-22 14:59 ` Jacopo Mondi
2021-02-24 20:35 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 02/16] media: i2c: rdacm20: Embedded 'serializer' field Jacopo Mondi
2021-02-17 12:56 ` Kieran Bingham
2021-02-22 0:58 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop Jacopo Mondi
2021-02-17 13:01 ` Kieran Bingham
2021-02-22 1:05 ` Laurent Pinchart
2021-02-22 15:06 ` Jacopo Mondi
2021-02-24 20:27 ` Laurent Pinchart
2021-02-25 8:56 ` Kieran Bingham
2021-02-16 17:41 ` [PATCH 04/16] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-02-17 13:02 ` Kieran Bingham
2021-02-22 1:06 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 05/16] media: i2c: rdacm20: Check return values Jacopo Mondi
2021-02-17 13:08 ` Kieran Bingham
2021-02-22 1:09 ` Laurent Pinchart
2021-02-22 15:08 ` Jacopo Mondi
2021-02-16 17:41 ` [PATCH 06/16] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi
2021-02-17 13:22 ` Kieran Bingham
2021-02-22 1:15 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 07/16] media: i2c: rdacm2x: Fix wake up delay Jacopo Mondi
2021-02-17 8:02 ` Geert Uytterhoeven
2021-02-17 13:33 ` Kieran Bingham
2021-02-22 1:18 ` Laurent Pinchart
2021-02-22 15:11 ` Jacopo Mondi
2021-02-24 20:29 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 08/16] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-02-17 13:36 ` Kieran Bingham
2021-02-22 1:20 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization Jacopo Mondi
2021-02-17 8:06 ` Geert Uytterhoeven
2021-02-17 13:55 ` Kieran Bingham
2021-02-22 1:27 ` Laurent Pinchart
2021-02-22 15:19 ` Jacopo Mondi
2021-02-24 20:30 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 10/16] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-02-17 8:07 ` Geert Uytterhoeven
2021-02-18 15:06 ` Kieran Bingham [this message]
2021-02-22 1:29 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 11/16] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-02-17 8:08 ` Geert Uytterhoeven
2021-02-18 15:39 ` Kieran Bingham
2021-02-22 1:33 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 12/16] media: i2c: max9286: Define high " Jacopo Mondi
2021-02-18 15:39 ` Kieran Bingham
2021-02-22 1:35 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 13/16] media: i2c: rdacm2x: Implement .init() subdev op Jacopo Mondi
2021-02-17 8:17 ` Geert Uytterhoeven
2021-02-18 16:13 ` Kieran Bingham
2021-02-22 1:52 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 14/16] media: i2c: max9286: Initialize remotes when bound Jacopo Mondi
2021-02-17 8:19 ` Geert Uytterhoeven
2021-02-18 16:00 ` Kieran Bingham
2021-02-22 2:03 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 15/16] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-02-18 16:03 ` Kieran Bingham
2021-02-16 17:41 ` [PATCH 16/16] media: i2c: gmsl: Use 339Kbps I2C bit-rate Jacopo Mondi
2021-02-17 8:19 ` Geert Uytterhoeven
2021-02-18 16:07 ` Kieran Bingham
2021-02-22 2:06 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e1cca71-e0f0-4d66-d3f5-268760c53eec@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).