From: Ludovic BARRE <ludovic.barre@st.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH V3 1/2] mmc: mmci: add variant property to set command stop bit
Date: Thu, 3 Jan 2019 11:35:34 +0100 [thread overview]
Message-ID: <9e22fd3d-f029-2a2a-18d1-af1987c94e4e@st.com> (raw)
In-Reply-To: <35f22c1a-888d-5abd-7ffe-ecf47a74b69a@st.com>
hi Ulf
happy new years.
Just a gentleman ping about patch2 of this series
"mmc: mmci: send stop command to clear the dpsm."
Regards
Ludo
On 12/11/18 10:53 AM, Ludovic BARRE wrote:
>
>
> On 12/11/18 10:47 AM, Ulf Hansson wrote:
>> On Thu, 6 Dec 2018 at 16:13, Ludovic Barre <ludovic.Barre@st.com> wrote:
>>>
>>> From: Ludovic Barre <ludovic.barre@st.com>
>>>
>>> On cmd12 (STOP_TRANSMISSION), STM32 sdmmc variant needs to set
>>> cmdstop bit in command register. The CPSM ("Command Path State Machine")
>>> treats the command as a Stop Transmission command and signals
>>> abort to the DPSM ("Data Path State Machine").
>>>
>>> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
>>
>> Applied for next, thanks!
>
> thanks
>
>>
>> Withholding patch2 for a while, as I need some more time to review it.
>
> No problem,
>
> Regards
> Ludo
>
>>
>> Kind regards
>> Uffe
>>
>>> ---
>>> drivers/mmc/host/mmci.c | 6 ++++++
>>> drivers/mmc/host/mmci.h | 2 ++
>>> 2 files changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
>>> index 13fa640..e352f5a 100644
>>> --- a/drivers/mmc/host/mmci.c
>>> +++ b/drivers/mmc/host/mmci.c
>>> @@ -21,6 +21,7 @@
>>> #include <linux/err.h>
>>> #include <linux/highmem.h>
>>> #include <linux/log2.h>
>>> +#include <linux/mmc/mmc.h>
>>> #include <linux/mmc/pm.h>
>>> #include <linux/mmc/host.h>
>>> #include <linux/mmc/card.h>
>>> @@ -274,6 +275,7 @@ static struct variant_data variant_stm32_sdmmc = {
>>> .cmdreg_lrsp_crc = MCI_CPSM_STM32_LRSP_CRC,
>>> .cmdreg_srsp_crc = MCI_CPSM_STM32_SRSP_CRC,
>>> .cmdreg_srsp = MCI_CPSM_STM32_SRSP,
>>> + .cmdreg_stop = MCI_CPSM_STM32_CMDSTOP,
>>> .data_cmd_enable = MCI_CPSM_STM32_CMDTRANS,
>>> .irq_pio_mask = MCI_IRQ_PIO_STM32_MASK,
>>> .datactrl_first = true,
>>> @@ -1100,6 +1102,10 @@ mmci_start_command(struct mmci_host *host,
>>> struct mmc_command *cmd, u32 c)
>>> mmci_reg_delay(host);
>>> }
>>>
>>> + if (host->variant->cmdreg_stop &&
>>> + cmd->opcode == MMC_STOP_TRANSMISSION)
>>> + c |= host->variant->cmdreg_stop;
>>> +
>>> c |= cmd->opcode | host->variant->cmdreg_cpsm_enable;
>>> if (cmd->flags & MMC_RSP_PRESENT) {
>>> if (cmd->flags & MMC_RSP_136)
>>> diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h
>>> index 550dd39..2422909 100644
>>> --- a/drivers/mmc/host/mmci.h
>>> +++ b/drivers/mmc/host/mmci.h
>>> @@ -264,6 +264,7 @@ struct mmci_host;
>>> * @cmdreg_lrsp_crc: enable value for long response with crc
>>> * @cmdreg_srsp_crc: enable value for short response with crc
>>> * @cmdreg_srsp: enable value for short response without crc
>>> + * @cmdreg_stop: enable value for stop and abort transmission
>>> * @datalength_bits: number of bits in the MMCIDATALENGTH register
>>> * @fifosize: number of bytes that can be written when
>>> MMCI_TXFIFOEMPTY
>>> * is asserted (likewise for RX)
>>> @@ -316,6 +317,7 @@ struct variant_data {
>>> unsigned int cmdreg_lrsp_crc;
>>> unsigned int cmdreg_srsp_crc;
>>> unsigned int cmdreg_srsp;
>>> + unsigned int cmdreg_stop;
>>> unsigned int datalength_bits;
>>> unsigned int fifosize;
>>> unsigned int fifohalfsize;
>>> --
>>> 2.7.4
>>>
next prev parent reply other threads:[~2019-01-03 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:13 [PATCH V3 0/2] mmc: mmci: add stop command Ludovic Barre
2018-12-06 15:13 ` [PATCH V3 1/2] mmc: mmci: add variant property to set command stop bit Ludovic Barre
2018-12-11 9:47 ` Ulf Hansson
2018-12-11 9:53 ` Ludovic BARRE
2019-01-03 10:35 ` Ludovic BARRE [this message]
2019-01-24 15:03 ` [Linux-stm32] " Ludovic BARRE
2019-01-24 15:12 ` Ulf Hansson
2018-12-06 15:13 ` [PATCH V3 2/2] mmc: mmci: send stop command to clear the dpsm Ludovic Barre
2019-01-29 14:31 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e22fd3d-f029-2a2a-18d1-af1987c94e4e@st.com \
--to=ludovic.barre@st.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).