From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: refactormyself@gmail.com, helgaas@kernel.org
Cc: bjorn@helgaas.com, linux-pci@vger.kernel.org,
skhan@linuxfoundation.org,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors
Date: Mon, 29 Jun 2020 16:09:21 -0400 [thread overview]
Message-ID: <9e2b006e-9a0a-19fb-5dab-52df8c0e8674@intel.com> (raw)
In-Reply-To: <20200615073225.24061-3-refactormyself@gmail.com>
On 6/15/2020 3:32 AM, refactormyself@gmail.com wrote:
> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
>
> pcie_speeds() returns PCIBIOS_ error codes from PCIe capability accessors.
>
> PCIBIOS_ error codes have positive values. Passing on these values is
> inconsistent with functions which return only a negative value on failure.
>
> Before passing on the return value of PCIe capability accessors, call
> pcibios_err_to_errno() to convert any positive PCIBIOS_ error codes to
> negative generic error values.
>
> Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
> ---
> drivers/infiniband/hw/hfi1/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
> index 1a6268d61977..eb53781d0c6a 100644
> --- a/drivers/infiniband/hw/hfi1/pcie.c
> +++ b/drivers/infiniband/hw/hfi1/pcie.c
> @@ -306,7 +306,7 @@ int pcie_speeds(struct hfi1_devdata *dd)
> ret = pcie_capability_read_dword(dd->pcidev, PCI_EXP_LNKCAP, &linkcap);
> if (ret) {
> dd_dev_err(dd, "Unable to read from PCI config\n");
> - return ret;
> + return pcibios_err_to_errno(ret);
> }
>
> if ((linkcap & PCI_EXP_LNKCAP_SLS) != PCI_EXP_LNKCAP_SLS_8_0GB) {
>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2020-06-29 20:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 7:32 [PATCH 0/8 v2] PCI: Align return values of PCIe capability and PCI accessors refactormyself
2020-06-15 7:32 ` [PATCH v2 1/8] dmaengine: ioatdma: Convert PCIBIOS_* errors to generic -E* errors refactormyself
2020-06-15 7:32 ` [PATCH v2 2/8] IB/hfi1: " refactormyself
2020-06-29 20:09 ` Dennis Dalessandro [this message]
2020-06-15 7:32 ` [PATCH v2 3/8] " refactormyself
2020-06-29 20:22 ` Dennis Dalessandro
2020-06-15 7:32 ` [PATCH v2 4/8] PCI: " refactormyself
2020-06-15 7:32 ` [PATCH v2 5/8] scsi: smartpqi: " refactormyself
2020-06-15 7:32 ` [PATCH v2 6/8] PCI/AER: " refactormyself
2020-06-15 7:32 ` [PATCH v2 7/8] " refactormyself
2020-06-15 7:32 ` [PATCH v2 8/8] PCI: Align return values of PCIe capability and PCI accessors refactormyself
2020-06-15 13:46 ` [PATCH 0/8 v2] " Jason Gunthorpe
2020-06-26 18:52 ` Bjorn Helgaas
2020-06-30 16:24 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e2b006e-9a0a-19fb-5dab-52df8c0e8674@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=bjorn@helgaas.com \
--cc=dledford@redhat.com \
--cc=helgaas@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=refactormyself@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).