From: Markus Elfring <Markus.Elfring@web.de>
To: Hanjun Guo <guohanjun@huawei.com>, Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mailbox: pcc: Put the PCCT table for error path
Date: Thu, 23 Jul 2020 07:33:41 +0200 [thread overview]
Message-ID: <9e4f09a9-d14f-d76c-5318-d25501c0ec66@web.de> (raw)
…
> In acpi_pcc_probe(), the PCCT table entries will be used as private
> data for communication chan at runtime, but the table should be put
> for error path.
* An imperative wording can be preferred for the change description,
can't it?
* Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
next reply other threads:[~2020-07-23 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 5:33 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-22 9:40 [PATCH] mailbox: pcc: Put the PCCT table for error path Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4f09a9-d14f-d76c-5318-d25501c0ec66@web.de \
--to=markus.elfring@web.de \
--cc=guohanjun@huawei.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).