From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <chao@kernel.org>
Subject: Re: [PATCH] f2fs: fix to account IO correctly
Date: Fri, 19 Oct 2018 10:23:31 +0800 [thread overview]
Message-ID: <9e586616-5cfa-5515-008c-e7bba1e3c4a1@huawei.com> (raw)
In-Reply-To: <20181018190612.GD50556@jaegeuk-macbookpro.roam.corp.google.com>
On 2018/10/19 3:06, Jaegeuk Kim wrote:
>
> On 10/17, Chao Yu wrote:
>> Below race can cause reversed reference on F2FS_RD_DATA, there is
>> the same issue in f2fs_submit_page_bio(), fix them by relocate
>> __submit_bio() and inc_page_count.
>>
>> Thread A Thread B
>> - f2fs_write_begin
>> - f2fs_submit_page_read
>> - __submit_bio
>> - f2fs_read_end_io
>> - __read_end_io
>> - dec_page_count(, F2FS_RD_DATA)
>> - inc_page_count(, F2FS_RD_DATA)
>
> Let me integrate the change into the original patch and test a bit.
IMO, it will be better to split this change into two, we can fix the
location of inc_page_count(, F2FS_RD_DATA) directly in your patch,
meanwhile we can add one more patch to fix the same issue in
f2fs_submit_page_bio(), in where the problem exists for long time, it needs
to send fixing patch to stable kernel mailing list.
Thanks,
>
> Thanks,
>
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/data.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
>> index c03bd0c2ed22..8b9240762156 100644
>> --- a/fs/f2fs/data.c
>> +++ b/fs/f2fs/data.c
>> @@ -480,10 +480,10 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio)
>> }
>> bio_set_op_attrs(bio, fio->op, fio->op_flags);
>>
>> - __submit_bio(fio->sbi, bio, fio->type);
>> -
>> inc_page_count(fio->sbi, is_read_io(fio->op) ?
>> __read_io_type(page): WB_DATA_TYPE(fio->page));
>> +
>> + __submit_bio(fio->sbi, bio, fio->type);
>> return 0;
>> }
>>
>> @@ -612,8 +612,8 @@ static int f2fs_submit_page_read(struct inode *inode, struct page *page,
>> return -EFAULT;
>> }
>> ClearPageError(page);
>> - __submit_bio(F2FS_I_SB(inode), bio, DATA);
>> inc_page_count(F2FS_I_SB(inode), F2FS_RD_DATA);
>> + __submit_bio(F2FS_I_SB(inode), bio, DATA);
>> return 0;
>> }
>>
>> --
>> 2.18.0.rc1
>
> .
>
next prev parent reply other threads:[~2018-10-19 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:49 [PATCH] f2fs: fix to account IO correctly Chao Yu
2018-10-18 19:06 ` Jaegeuk Kim
2018-10-19 2:23 ` Chao Yu [this message]
2018-10-19 23:12 ` Jaegeuk Kim
2018-10-22 1:15 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e586616-5cfa-5515-008c-e7bba1e3c4a1@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).