From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B73C6778D for ; Wed, 12 Sep 2018 16:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4C3E20880 for ; Wed, 12 Sep 2018 16:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C3E20880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbeILVQ0 convert rfc822-to-8bit (ORCPT ); Wed, 12 Sep 2018 17:16:26 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:55019 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbeILVQ0 (ORCPT ); Wed, 12 Sep 2018 17:16:26 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-90-4yHxpl17OkaAEmZvN9gB5w-1; Wed, 12 Sep 2018 17:10:06 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 12 Sep 2018 17:12:17 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 12 Sep 2018 17:12:17 +0100 From: David Laight To: 'Arnd Bergmann' , "viro@zeniv.linux.org.uk" CC: "linux-fsdevel@vger.kernel.org" , "stable@vger.kernel.org" , "Yan, Zheng" , Sage Weil , Ilya Dryomov , Chengguang Xu , "ceph-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations Thread-Topic: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations Thread-Index: AQHUSqquiaU+csxrX0GJf2dwmCHs0KTs0QpA Date: Wed, 12 Sep 2018 16:12:17 +0000 Message-ID: <9e5f6ad82a2344c095234b39224605d4@AcuMS.aculab.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-4-arnd@arndb.de> In-Reply-To: <20180912150142.157913-4-arnd@arndb.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: 4yHxpl17OkaAEmZvN9gB5w-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann > Sent: 12 September 2018 16:01 > > The ceph_ioctl function is used both for files and directories, but only > the files support doing that in 32-bit compat mode. > > For consistency, add the same compat handler to the dir operations > as well. Have you verified that all the relevant ioctl buffer structures are exactly the same for 32bit and 64bit applications? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)