From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877ABC43331 for ; Fri, 27 Mar 2020 13:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61A102082E for ; Fri, 27 Mar 2020 13:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727541AbgC0NCV (ORCPT ); Fri, 27 Mar 2020 09:02:21 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33150 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbgC0NCV (ORCPT ); Fri, 27 Mar 2020 09:02:21 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 1294B297E16 Message-ID: <9e863f96cd9a188db84ae8bc5a0d49287b4b4922.camel@collabora.com> Subject: Re: [PATCH] iommu: Lower severity of add/remove device messages From: Ezequiel Garcia To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, kernel@collabora.com, linux-kernel@vger.kernel.org Date: Fri, 27 Mar 2020 10:02:11 -0300 In-Reply-To: <20200327095029.GB11538@8bytes.org> References: <20200323214956.30165-1-ezequiel@collabora.com> <20200327095029.GB11538@8bytes.org> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Joerg, Thanks for reviewing. I understand this change bears some controversy for IOMMU, as developers are probably used to see these messages. On Fri, 2020-03-27 at 10:50 +0100, Joerg Roedel wrote: > On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote: > > These user messages are not really informational, > > but mostly of debug nature. Lower their severity. > > Like most other messages in the kernel log, that is not a reason to > lower the severity. > > These messages are the first thing to look at when > looking into IOMMU related issues. > Sure, but the messages are still here, you can always enable them when you are looking at IOMMU issues :-) The idea is to reduce the amount of verbosity in the kernel. If all subsystems would print messages that are useful when looking at issues, things would be quite nasty verbose. Thanks! Ezequiel