From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966111AbcJ0OeY (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Oct 2016 10:34:24 -0400
Received: from mail-wm0-f49.google.com ([74.125.82.49]:38131 "EHLO
        mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S942929AbcJ0OdY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Oct 2016 10:33:24 -0400
Subject: Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol
 warnings
To: Sekhar Nori <nsekhar@ti.com>, gregkh@linuxfoundation.org,
        khilman@baylibre.com
References: <1477485542-10555-1-git-send-email-abailon@baylibre.com>
 <1477485542-10555-2-git-send-email-abailon@baylibre.com>
 <7026f012-ffce-cc28-85be-9a5cd26de60f@ti.com>
 <ca32fd12-5299-02e8-24c4-501dda4291ab@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
From: Alexandre Bailon <abailon@baylibre.com>
Message-ID: <9ea6a516-86de-e0a3-5a07-d02c60bb820c@baylibre.com>
Date: Thu, 27 Oct 2016 16:33:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <ca32fd12-5299-02e8-24c4-501dda4291ab@ti.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/27/2016 01:54 PM, Sekhar Nori wrote:
> On Thursday 27 October 2016 05:13 PM, Sekhar Nori wrote:
>> On Wednesday 26 October 2016 06:09 PM, Alexandre Bailon wrote:
>>> Some macro for DA8xx CFGCHIP are defined in usb-davinci.h,
>>> but da8xx-cfgchip.h intend to replace them.
>>> The usb-da8xx.c is using both headers, causing redefined symbol warnings.
>>
>> Looks like this is not true for v4.9-rc2 and so I don't see any warnings
> 
> Ah, just noticed that _this_ is the patch that introduces
> da8xx-cfgchip.h into usb-da8xx.c. So this is the patch that introduces
> the warnings (and fixes them).
> 
> I can queue this for v4.10 (with Greg's ack) if you change the
> description to make it about cleaning up duplicated defines between
> da8xx-cfgchip.h and usb-davinci.h and not talk about "redefined symbol
> warnings".
I will do it.
> 
> Also, when adding a header file, can you please keep it sorted in
> alphabetical order.
Ok.
> 
> Thanks,
> Sekhar
> 
Thanks,
Alexandre