From: Matthias Brugger <matthias.bgg@gmail.com>
To: sean.wang@mediatek.com, herbert@gondor.apana.org.au,
mpm@selenic.com, robh+dt@kernel.org, mark.rutland@arm.com,
clabbe.montjoie@gmail.com, prasannatsmkumar@gmail.com,
romain.perier@free-electrons.com, shannon.nelson@oracle.com
Cc: devicetree@vger.kernel.org, keyhaede@gmail.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-crypto@vger.kernel.org, weiyongjun1@huawei.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs
Date: Tue, 6 Jun 2017 13:07:44 +0200 [thread overview]
Message-ID: <9eb87222-ca89-0abb-4532-3887008f6e7a@gmail.com> (raw)
In-Reply-To: <1d9c981e1b45bf2f04732a02d90e6857cc203ce5.1496255334.git.sean.wang@mediatek.com>
On 31/05/17 20:44, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Add the generic binding for allowing the support of RNG on MediaTek SoCs
> such as MT7622.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/rng/mtk-rng.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.txt b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> index a6d62a2..0772913 100644
> --- a/Documentation/devicetree/bindings/rng/mtk-rng.txt
> +++ b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> @@ -2,7 +2,8 @@ Device-Tree bindings for Mediatek random number generator
> found in Mediatek SoC family
>
> Required properties:
> -- compatible : Should be "mediatek,mt7623-rng"
> +- compatible : Should be "mediatek,generic-rng" or
> + "mediatek,mt7623-rng".
What does generic-rng mean. Is it for all mt7xxx, or also for mt6xxx and
mt8xxx based SoCs? I think we should stick with SoC specific bindings,
as we don't know if Mediatek won't publish a new IP block next year
which is differnet.
Just in case we should add a binding for the actual SoC + a fallback.
For example.
- compatible " Should be
"mediatek,mt7622-rng", "mediatek,mt7623-rng" for SoC mt7622
"mediatek,mt7623-rng" for SoC mt7623
This will also eliminate the need of adding mt6722-rng to the driver, as
it will use mt7623-rng as fallback. If in the future we realize that
mt7622-rng has a extra feature/bug, we can still work around it, without
breaking the bindings.
Makes sense?
Regards,
Matthias
> - clocks : list of clock specifiers, corresponding to
> entries in clock-names property;
> - clock-names : Should contain "rng" entries;
>
next prev parent reply other threads:[~2017-06-06 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1496255334.git.sean.wang@mediatek.com>
2017-05-31 18:44 ` [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek SoCs sean.wang
2017-06-06 11:07 ` Matthias Brugger [this message]
2017-06-07 13:20 ` Sean Wang
2017-06-07 13:25 ` Matthias Brugger
2017-06-07 14:48 ` Sean Wang
2017-05-31 18:44 ` [PATCH 2/4] hwrng: mtk - add support for MT7622 SoC sean.wang
2017-05-31 18:44 ` [PATCH 3/4] hwrng: mtk - add runtime PM support sean.wang
2017-05-31 18:44 ` [PATCH 4/4] MAINTAINERS: add entry for MediaTek Random Number Generator sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eb87222-ca89-0abb-4532-3887008f6e7a@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=keyhaede@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=prasannatsmkumar@gmail.com \
--cc=robh+dt@kernel.org \
--cc=romain.perier@free-electrons.com \
--cc=sean.wang@mediatek.com \
--cc=shannon.nelson@oracle.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).