From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751803AbcL1Pzg (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Dec 2016 10:55:36 -0500
Received: from muin.pair.com ([209.68.1.55]:55343 "EHLO muin.pair.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751293AbcL1Pzf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Dec 2016 10:55:35 -0500
X-Greylist: delayed 355 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Dec 2016 10:55:34 EST
Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode
To: Andreas Schwab <schwab@linux-m68k.org>,
        "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.com>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>, Xiubo Li <Xiubo.Lee@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20161228110636.GA14768@ubuntu> <87inq4f6pa.fsf@linux-m68k.org>
From: Timur Tabi <timur@tabi.org>
Message-ID: <9ebb798c-6040-9262-9625-ddcebd05a188@tabi.org>
Date: Wed, 28 Dec 2016 09:48:42 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:49.0)
 Gecko/20100101 Firefox/49.0 SeaMonkey/2.46
MIME-Version: 1.0
In-Reply-To: <87inq4f6pa.fsf@linux-m68k.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andreas Schwab wrote:
>> > +	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
>> > +		SND_SOC_DAIFMT_AC97;
> This is never true.

I think the right parenthesis should be at the end of the expression.