From: Quentin Schulz <quentin.schulz@bootlin.com>
To: sre@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
wens@csie.org, linux@armlinux.org.uk, maxime.ripard@bootlin.com,
jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
lee.jones@linaro.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
thomas.petazzoni@bootlin.com, linux-sunxi@googlegroups.com,
Quentin Schulz <quentin.schulz@bootlin.com>
Subject: [PATCH v4 13/13] iio: adc: axp20x_adc: remove !! in favor of ternary condition
Date: Mon, 19 Feb 2018 13:47:36 +0100 [thread overview]
Message-ID: <9ec180ff4358ac6e163115aa7832a0674b6a640e.1519044068.git-series.quentin.schulz@bootlin.com> (raw)
In-Reply-To: <cover.6545459c99a33874413abf619136986f53d2c2a2.1519044068.git-series.quentin.schulz@bootlin.com>
In-Reply-To: <cover.6545459c99a33874413abf619136986f53d2c2a2.1519044068.git-series.quentin.schulz@bootlin.com>
!!'s behaviour isn't that obvious and sparse complained about it, so
let's replace it with a ternary condition.
Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
---
drivers/iio/adc/axp20x_adc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
index a30a972..7a745cf 100644
--- a/drivers/iio/adc/axp20x_adc.c
+++ b/drivers/iio/adc/axp20x_adc.c
@@ -365,7 +365,7 @@ static int axp20x_adc_offset_voltage(struct iio_dev *indio_dev, int channel,
return -EINVAL;
}
- *val = !!(*val) * 700000;
+ *val = *val ? 700000 : 0;
return IIO_VAL_INT;
}
@@ -442,15 +442,17 @@ static int axp20x_write_raw(struct iio_dev *indio_dev,
if (val != 0 && val != 700000)
return -EINVAL;
+ val = val ? 1 : 0;
+
switch (chan->channel) {
case AXP20X_GPIO0_V:
reg = AXP20X_GPIO10_IN_RANGE_GPIO0;
- regval = AXP20X_GPIO10_IN_RANGE_GPIO0_VAL(!!val);
+ regval = AXP20X_GPIO10_IN_RANGE_GPIO0_VAL(val);
break;
case AXP20X_GPIO1_V:
reg = AXP20X_GPIO10_IN_RANGE_GPIO1;
- regval = AXP20X_GPIO10_IN_RANGE_GPIO1_VAL(!!val);
+ regval = AXP20X_GPIO10_IN_RANGE_GPIO1_VAL(val);
break;
default:
--
git-series 0.9.1
next prev parent reply other threads:[~2018-02-19 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 12:47 [PATCH v4 00/13] add support for AXP813 ADC and battery power supply Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 01/13] ARM: dtsi: axp209: add node for ADC Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 02/13] ARM: dtsi: axp22x: " Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 03/13] mfd: axp20x: make AXP209/22x cells probe their ADC via DT Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 04/13] ARM: dtsi: axp81x: add node for ADC Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 05/13] mfd: axp20x: probe axp20x_adc driver for AXP813 Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 06/13] power: supply: axp20x_battery: use data struct for variant specific code Quentin Schulz
2018-02-20 9:12 ` kbuild test robot
2018-02-20 9:12 ` [RFC PATCH] power: supply: axp20x_battery: axp209_data can be static kbuild test robot
2018-02-19 12:47 ` [PATCH v4 07/13] dt-bindings: power: supply: axp20x: add AXP813 battery DT binding Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 08/13] power: supply: axp20x_battery: add support for AXP813 Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 09/13] mfd: axp20x: add battery power supply cell " Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 10/13] ARM: dtsi: axp81x: add battery power supply subnode Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 11/13] ARM: dtsi: sun8i: a711: enable " Quentin Schulz
2018-02-19 12:47 ` [PATCH v4 12/13] ARM: dtsi: axp81x: remove IP name from DT node name Quentin Schulz
2018-02-19 12:47 ` Quentin Schulz [this message]
2018-02-24 12:20 ` [PATCH v4 13/13] iio: adc: axp20x_adc: remove !! in favor of ternary condition Jonathan Cameron
2018-02-21 9:51 ` [PATCH v4 00/13] add support for AXP813 ADC and battery power supply Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec180ff4358ac6e163115aa7832a0674b6a640e.1519044068.git-series.quentin.schulz@bootlin.com \
--to=quentin.schulz@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).