From: <Conor.Dooley@microchip.com>
To: <heinrich.schuchardt@canonical.com>
Cc: <Daire.McNamara@microchip.com>,
<Valentina.FernandezAlanis@microchip.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <gregkh@linuxfoundation.org>,
<b-liu@ti.com>
Subject: Re: [PATCH 3/3] riscv: dts: microchip: fix icicle kit's dr_mode
Date: Wed, 8 Jun 2022 12:49:06 +0000 [thread overview]
Message-ID: <9ec92e13-2af1-e65a-b24f-7acf895a40ee@microchip.com> (raw)
In-Reply-To: <244df608-ef96-d3f2-2463-1cc82728e70f@canonical.com>
On 08/06/2022 13:21, Heinrich Schuchardt wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 6/7/22 15:22, Conor Dooley wrote:
>> The usb on icicle kit is actually configured for otg, not host mode.
>> Swap it over.
>
> To my understanding both host mode and OTG mode could be supported by
> the hardware.
>
> Jumper J17 on
> https://www.microsemi.com/images/10/MicrosoftTeams-image%201.png.
> USB device mode selection - Open: USB client. Closed: USB host
>
> Is OTG really the most important scenario for running the board? I
> personally would prefer to run it in host mode to add more peripherals.
> What is missing on the driver side to enable host mode?
Nothing. I'll drop the the patch for v2 :)
> Can we detect the 5 Volt jumper setting via GPIO?
I have to check if a GPIO can be routed that way & I'll get back to you.
Thanks,
Conor.
>
> Best regards
>
> Heinrich
>
>>
>> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
>> Signed-off-by: Conor Dooley<conor.dooley@microchip.com>
>> ---
>> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>> index 044982a11df5..121b01c8784f 100644
>> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
>> @@ -158,5 +158,5 @@ &syscontroller {
>>
>> &usb {
>> status = "okay";
>> - dr_mode = "host";
>> + dr_mode = "otg";
>> };
>> -- 2.36.1
>
next prev parent reply other threads:[~2022-06-08 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 13:22 [PATCH 0/3] Add support for PolarFire SoC's musb controller Conor Dooley
2022-06-07 13:22 ` [PATCH 1/3] usb: musb: " Conor Dooley
2022-06-07 15:18 ` Ben Dooks
2022-06-12 22:14 ` Conor.Dooley
2022-06-07 13:22 ` [PATCH 2/3] MAINTAINERS: add musb to PolarFire SoC entry Conor Dooley
2022-06-07 13:22 ` [PATCH 3/3] riscv: dts: microchip: fix icicle kit's dr_mode Conor Dooley
2022-06-08 12:21 ` Heinrich Schuchardt
2022-06-08 12:49 ` Conor.Dooley [this message]
2022-06-09 8:23 ` Conor.Dooley
2022-06-07 17:53 ` [PATCH 0/3] Add support for PolarFire SoC's musb controller Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec92e13-2af1-e65a-b24f-7acf895a40ee@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).