From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mux: Remove usage of the deprecated ida_simple_xx() API
Date: Thu, 8 Feb 2024 18:57:25 +0100 [thread overview]
Message-ID: <9edc26e9-4f31-496a-969d-0edc33ef6f01@wanadoo.fr> (raw)
In-Reply-To: <727714bdfcd69d21e7f2a0c5c7426fcb70439b91.1702228605.git.christophe.jaillet@wanadoo.fr>
Le 10/12/2023 à 18:17, Christophe JAILLET a écrit :
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
>
> This is less verbose.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/mux/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mux/core.c b/drivers/mux/core.c
> index 775816112932..78c0022697ec 100644
> --- a/drivers/mux/core.c
> +++ b/drivers/mux/core.c
> @@ -64,7 +64,7 @@ static void mux_chip_release(struct device *dev)
> {
> struct mux_chip *mux_chip = to_mux_chip(dev);
>
> - ida_simple_remove(&mux_ida, mux_chip->id);
> + ida_free(&mux_ida, mux_chip->id);
> kfree(mux_chip);
> }
>
> @@ -111,7 +111,7 @@ struct mux_chip *mux_chip_alloc(struct device *dev,
> mux_chip->dev.of_node = dev->of_node;
> dev_set_drvdata(&mux_chip->dev, mux_chip);
>
> - mux_chip->id = ida_simple_get(&mux_ida, 0, 0, GFP_KERNEL);
> + mux_chip->id = ida_alloc(&mux_ida, GFP_KERNEL);
> if (mux_chip->id < 0) {
> int err = mux_chip->id;
>
Hi,
gentle reminder.
All patches to remove the ida_simple API have been sent.
And Matthew Wilcox seems happy with the on going work. (see [1])
Based on next-20240207
$git grep ida_simple_get | wc -l
38
https://elixir.bootlin.com/linux/v6.8-rc3/A/ident/ida_simple_get
50
https://elixir.bootlin.com/linux/v6.7.4/A/ident/ida_simple_get
81
Thanks
CJ
[1]: https://lore.kernel.org/all/ZaqruGVz734zjxrZ@casper.infradead.org/
prev parent reply other threads:[~2024-02-08 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 17:17 [PATCH] mux: Remove usage of the deprecated ida_simple_xx() API Christophe JAILLET
2024-02-08 17:57 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9edc26e9-4f31-496a-969d-0edc33ef6f01@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).