* [PATCH][next] rtlwifi: rtl8192de: Fix uninitialized variable place
@ 2021-08-29 18:05 Colin King
2021-08-30 2:00 ` Pkshih
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-08-29 18:05 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
In the case where chnl <= 14 variable place is not initialized and
the function returns an uninitialized value. This fixes an earlier
cleanup where I introduced this bug. My bad.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 369956ae5720 ("rtlwifi: rtl8192de: Remove redundant variable initializations")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
index 8ae69d914312..b32fa7a75f17 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
@@ -896,7 +896,7 @@ static void _rtl92d_ccxpower_index_check(struct ieee80211_hw *hw,
static u8 _rtl92c_phy_get_rightchnlplace(u8 chnl)
{
- u8 place;
+ u8 place = chnl;
if (chnl > 14) {
for (place = 14; place < sizeof(channel5g); place++) {
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH][next] rtlwifi: rtl8192de: Fix uninitialized variable place
2021-08-29 18:05 [PATCH][next] rtlwifi: rtl8192de: Fix uninitialized variable place Colin King
@ 2021-08-30 2:00 ` Pkshih
0 siblings, 0 replies; 2+ messages in thread
From: Pkshih @ 2021-08-30 2:00 UTC (permalink / raw)
To: Colin King, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Monday, August 30, 2021 2:05 AM
> To: Pkshih; Kalle Valo; David S . Miller; Jakub Kicinski; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][next] rtlwifi: rtl8192de: Fix uninitialized variable place
>
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where chnl <= 14 variable place is not initialized and
> the function returns an uninitialized value. This fixes an earlier
> cleanup where I introduced this bug. My bad.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 369956ae5720 ("rtlwifi: rtl8192de: Remove redundant variable initializations")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index 8ae69d914312..b32fa7a75f17 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -896,7 +896,7 @@ static void _rtl92d_ccxpower_index_check(struct ieee80211_hw *hw,
>
> static u8 _rtl92c_phy_get_rightchnlplace(u8 chnl)
> {
> - u8 place;
> + u8 place = chnl;
>
> if (chnl > 14) {
> for (place = 14; place < sizeof(channel5g); place++) {
Nathan Chancellor has sent a patch [1] to fix this, and the patch
has been merged.
[1] https://patchwork.kernel.org/project/linux-wireless/patch/20210823222014.764557-1-nathan@kernel.org/
--
Ping-Ke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-30 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-29 18:05 [PATCH][next] rtlwifi: rtl8192de: Fix uninitialized variable place Colin King
2021-08-30 2:00 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).