From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Yuriy Kolerov <yuriy.kolerov@synopsys.com>,
<linux-snps-arc@lists.infradead.org>
Cc: <marc.zyngier@arm.com>, <Vineet.Gupta1@synopsys.com>,
<Alexey.Brodkin@synopsys.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] ARCv2: IRQ: Remove option for setting number of interrupts
Date: Mon, 30 Jan 2017 10:59:29 -0800 [thread overview]
Message-ID: <9f1d05bc-2d86-6127-6dfb-742ed4531be0@synopsys.com> (raw)
In-Reply-To: <1485561703-20921-5-git-send-email-yuriy.kolerov@synopsys.com>
On 01/27/2017 04:01 PM, Yuriy Kolerov wrote:
> When you set a value of ARC_NUMBER_OF_INTERRUPTS option
> it affects only a size of the interrupts table but macros
> for number of virtual interrupts (NR_IRQS) and for number
> of hardware interrupts (NR_CPU_IRQS) remain unchanged.
> Moreover usage of ARC_NUMBER_OF_INTERRUPTS is bad for
> portability since it is not possible to change size
> of the interrupts table after linkage.
>
> This patch makes these changes in IRQ subsystem:
>
> * NR_CPU_IRQS defines a maximum number of hardware interrupts.
> * Remove ARC_NUMBER_OF_INTERRUPTS option and create interrupts
> table for all possible hardware interrupts.
> * Increase a maximum number of virtual IRQs to 512. ARCv2 can
> support 240 interrupts in the core interrupts controllers
> and 128 interrupts in IDU. Thus 512 virtual IRQs must be
> enough for most configurations of boards.
>
> Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
LGTM.
Thx,
-Vineet
> ---
> arch/arc/Kconfig | 11 -----------
> arch/arc/include/asm/irq.h | 28 +++++++++++++++++++++++++---
> arch/arc/kernel/entry-arcv2.S | 3 ++-
> 3 files changed, 27 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
> index 283099c..ba15cb8 100644
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -412,17 +412,6 @@ config ARC_HAS_DIV_REM
> bool "Insn: div, divu, rem, remu"
> default y
>
> -config ARC_NUMBER_OF_INTERRUPTS
> - int "Number of interrupts"
> - range 8 240
> - default 32
> - help
> - This defines the number of interrupts on the ARCv2HS core.
> - It affects the size of vector table.
> - The initial 8 IRQs are fixed (Timer, ICI etc) and although configurable
> - in hardware, it keep things simple for Linux to assume they are always
> - present.
> -
> endif # ISA_ARCV2
>
> endmenu # "ARC CPU Configuration"
> diff --git a/arch/arc/include/asm/irq.h b/arch/arc/include/asm/irq.h
> index e61ad30..dfa09e3 100644
> --- a/arch/arc/include/asm/irq.h
> +++ b/arch/arc/include/asm/irq.h
> @@ -9,19 +9,41 @@
> #ifndef __ASM_ARC_IRQ_H
> #define __ASM_ARC_IRQ_H
>
> -#define NR_CPU_IRQS 32 /* number of interrupt lines of ARC770 CPU */
> -#define NR_IRQS 128 /* allow some CPU external IRQ handling */
> +#ifdef CONFIG_ISA_ARCV2
> +
> +/*
> + * A maximum number of supported interrupts in the core interrupt controller.
> + * This number is not equal to the maximum interrupt number (256) because
> + * first 16 lines are reserved for exceptions and are not configurable.
> + */
> +#define NR_CPU_IRQS 240
> +
> +/*
> + * ARCv2 can support 240 interrupts in the core interrupts controllers and
> + * 128 interrupts in IDU. Thus 512 virtual IRQs must be enough for most
> + * configurations of boards.
> + */
> +#define NR_IRQS 512
>
> /* Platform Independent IRQs */
> -#ifdef CONFIG_ISA_ARCV2
> #define IPI_IRQ 19
> #define SOFTIRQ_IRQ 21
> #define FIRST_EXT_IRQ 24
> +
> +#else
> +
> +#define NR_CPU_IRQS 32 /* number of interrupt lines of ARC770 CPU */
> +#define NR_IRQS 128 /* allow some CPU external IRQ handling */
> +
> #endif
>
> +#ifndef __ASSEMBLY__
> +
> #include <linux/interrupt.h>
> #include <asm-generic/irq.h>
>
> extern void arc_init_IRQ(void);
>
> #endif
> +
> +#endif
> diff --git a/arch/arc/kernel/entry-arcv2.S b/arch/arc/kernel/entry-arcv2.S
> index 0b6388a..f22101e 100644
> --- a/arch/arc/kernel/entry-arcv2.S
> +++ b/arch/arc/kernel/entry-arcv2.S
> @@ -13,6 +13,7 @@
> #include <asm/errno.h>
> #include <asm/arcregs.h>
> #include <asm/irqflags.h>
> +#include <asm/irq.h>
>
> .cpu HS
>
> @@ -52,7 +53,7 @@ VECTOR handle_interrupt ; unused
> VECTOR handle_interrupt ; (23) unused
> # End of fixed IRQs
>
> -.rept CONFIG_ARC_NUMBER_OF_INTERRUPTS - 8
> +.rept NR_CPU_IRQS - 8
> VECTOR handle_interrupt
> .endr
>
>
next prev parent reply other threads:[~2017-01-30 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 0:01 [PATCH 0/6] Use build registers for getting numbers of interrupts Yuriy Kolerov
2017-01-28 0:01 ` [PATCH 1/6] ARCv2: IRQ: Move structures for core intc to the header Yuriy Kolerov
2017-01-30 18:56 ` Vineet Gupta
2017-01-28 0:01 ` [PATCH 2/6] ARCv2: MCIP: Add structure for build register of IDU Yuriy Kolerov
2017-01-30 18:57 ` Vineet Gupta
2017-01-28 0:01 ` [PATCH 3/6] ARCv2: IRQ: Add macro for the first external interrupt number Yuriy Kolerov
2017-01-30 19:01 ` Vineet Gupta
2017-01-28 0:01 ` [PATCH 4/6] ARCv2: IRQ: Remove option for setting number of interrupts Yuriy Kolerov
2017-01-30 18:59 ` Vineet Gupta [this message]
2017-01-28 0:01 ` [PATCH 5/6] ARCv2: IRQ: Use build registers for getting numbers " Yuriy Kolerov
2017-01-28 0:01 ` [PATCH 6/6] ARCv2: IRQ: Set a default priority for all core interrupts Yuriy Kolerov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f1d05bc-2d86-6127-6dfb-742ed4531be0@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=yuriy.kolerov@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).