From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Zheng Bin <zhengbin13@huawei.com>,
lgirdwood@gmail.com, ranjani.sridharan@linux.intel.com,
kai.vehmanen@linux.intel.com, daniel.baluta@nxp.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
peter.ujfalusi@linux.intel.com,
sound-open-firmware@alsa-project.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: limingming.li@huawei.com, tangyizhou@huawei.com
Subject: Re: [PATCH -next] ASoC: SOF: Intel: Fix build error without SND_SOC_SOF_PCI_DEV
Date: Wed, 23 Mar 2022 09:57:06 -0500 [thread overview]
Message-ID: <9f44016c-4774-64b3-4485-630401710568@linux.intel.com> (raw)
In-Reply-To: <20220323092501.145879-1-zhengbin13@huawei.com>
On 3/23/22 04:25, Zheng Bin wrote:
> If SND_SOC_SOF_PCI_DEV is n, bulding fails:
>
> sound/soc/sof/intel/pci-tng.o:(.data+0x1c0): undefined reference to `sof_pci_probe'
> sound/soc/sof/intel/pci-tng.o:(.data+0x1c8): undefined reference to `sof_pci_remove'
> sound/soc/sof/intel/pci-tng.o:(.data+0x1e0): undefined reference to `sof_pci_shutdown'
> sound/soc/sof/intel/pci-tng.o:(.data+0x290): undefined reference to `sof_pci_pm'
>
> Make SND_SOC_SOF_MERRIFIELD select SND_SOC_SOF_PCI_DEV to fix this.
>
> Fixes: 8d4ba1be3d22 ("ASoC: SOF: pci: split PCI into different drivers")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Indeed that's a miss, thanks for the patch. We select
SND_SOC_SOF_PCI_DEV for all HDaudio-based PCI devices but forgot
Merrifield which is PCI-based but not HDaudio-based.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/sof/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index b53f216d4ecc..172419392b33 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -84,6 +84,7 @@ if SND_SOC_SOF_PCI
> config SND_SOC_SOF_MERRIFIELD
> tristate "SOF support for Tangier/Merrifield"
> default SND_SOC_SOF_PCI
> + select SND_SOC_SOF_PCI_DEV
> select SND_SOC_SOF_INTEL_ATOM_HIFI_EP
> help
> This adds support for Sound Open Firmware for Intel(R) platforms
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-03-23 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:25 [PATCH -next] ASoC: SOF: Intel: Fix build error without SND_SOC_SOF_PCI_DEV Zheng Bin
2022-03-23 14:57 ` Pierre-Louis Bossart [this message]
2022-03-25 20:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f44016c-4774-64b3-4485-630401710568@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=limingming.li@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tangyizhou@huawei.com \
--cc=tiwai@suse.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).