* Re: [PATCH] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
[not found] <20201203231847.1484900-1-arnd@kernel.org>
@ 2020-12-04 1:57 ` santosh.shilimkar
0 siblings, 0 replies; only message in thread
From: santosh.shilimkar @ 2020-12-04 1:57 UTC (permalink / raw)
To: Arnd Bergmann, soc, Santosh Shilimkar
Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel
On 12/3/20 3:18 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
>
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
>
> In file included from /git/arm-soc/arch/arm/mach-keystone/keystone.c:24:
> arch/arm/mach-keystone/memory.h:10:9: warning: 'SECTION_SIZE_BITS' macro redefined [-Wmacro-redefined]
> #define SECTION_SIZE_BITS 34
> ^
> arch/arm/include/asm/sparsemem.h:23:9: note: previous definition is here
> #define SECTION_SIZE_BITS 28
> ^
>
> Clearly the definitions never had any effect here, so remove them.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
^ permalink raw reply [flat|nested] only message in thread