From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
broonie@kernel.org, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, p.zabel@pengutronix.de,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] spi: bcm63xx: add BMIPS support
Date: Mon, 15 Jun 2020 09:27:47 -0700 [thread overview]
Message-ID: <9f55d5a6-f936-cb73-6128-31a196dc5e47@gmail.com> (raw)
In-Reply-To: <20200615090943.2936839-1-noltari@gmail.com>
Hi Alvaro,
On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote:
> BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318,
> BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268).
>
> v2: use devm_reset_control_get_exclusive
We would also need to write a binding document for these two
controllers, as they appear to be missing, and this would document the
reset property.
I also believe that you should be making this property optional since
not all SoCs do have a dedicated reset controller line for SPI/HSSPI (if
at all).
Thank you!
--
Florian
prev parent reply other threads:[~2020-06-15 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 8:03 [PATCH 0/4] spi: bcm63xx: add BMIPS support Álvaro Fernández Rojas
2020-06-15 8:03 ` [PATCH 1/4] spi: bcm63xx-spi: add reset support Álvaro Fernández Rojas
2020-06-15 8:12 ` Philipp Zabel
2020-06-15 8:03 ` [PATCH 2/4] spi: bcm63xx-spi: allow building for BMIPS Álvaro Fernández Rojas
2020-06-15 8:03 ` [PATCH 3/4] spi: bcm63xx-hsspi: add reset support Álvaro Fernández Rojas
2020-06-15 8:03 ` [PATCH 4/4] spi: bcm63xx-hsspi: allow building for BMIPS Álvaro Fernández Rojas
2020-06-15 9:09 ` [PATCH v2 0/4] spi: bcm63xx: add BMIPS support Álvaro Fernández Rojas
2020-06-15 9:09 ` [PATCH v2 1/4] spi: bcm63xx-spi: add reset support Álvaro Fernández Rojas
2020-06-15 16:26 ` Florian Fainelli
2020-06-15 9:09 ` [PATCH v2 2/4] spi: bcm63xx-spi: allow building for BMIPS Álvaro Fernández Rojas
2020-06-15 16:26 ` Florian Fainelli
2020-06-15 9:09 ` [PATCH v2 3/4] spi: bcm63xx-hsspi: add reset support Álvaro Fernández Rojas
2020-06-15 9:09 ` [PATCH v2 4/4] spi: bcm63xx-hsspi: allow building for BMIPS Álvaro Fernández Rojas
2020-06-15 16:26 ` Florian Fainelli
2020-06-15 11:26 ` [PATCH v2 0/4] spi: bcm63xx: add BMIPS support Mark Brown
2020-06-15 16:27 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f55d5a6-f936-cb73-6128-31a196dc5e47@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).