From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbdILKwr (ORCPT ); Tue, 12 Sep 2017 06:52:47 -0400 Received: from mail-ve1eur01on0053.outbound.protection.outlook.com ([104.47.1.53]:60628 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751313AbdILKwp (ORCPT ); Tue, 12 Sep 2017 06:52:45 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Oleksandr_Tyshchenko@epam.com; Subject: Re: [v4,0/3] iommu/ipmmu-vmsa: r8a7796 support V4 From: Oleksandr To: Magnus Damm Cc: joro@8bytes.org, laurent.pinchart+renesas@ideasonboard.com, geert+renesas@glider.be, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, iommu@lists.linux-foundation.org, horms+renesas@verge.net.au, robin.murphy@arm.com, m.szyprowski@samsung.com, olekstysh@gmail.com References: <149787025647.32495.1584960416060100962.sendpatchset@little-apple> <934fcc8c-4716-e027-12aa-297ad0e55535@epam.com> Message-ID: <9f59e912-24df-cfde-538c-f8c78480c29b@epam.com> Date: Tue, 12 Sep 2017 13:52:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <934fcc8c-4716-e027-12aa-297ad0e55535@epam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.223.209.53] X-ClientProxiedBy: DB6PR1001CA0045.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::31) To VI1PR03MB2894.eurprd03.prod.outlook.com (2603:10a6:802:2d::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6315888-6d56-4c9d-2945-08d4f9cc648e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR03MB2894; X-Microsoft-Exchange-Diagnostics: 1;VI1PR03MB2894;3:b5AgkoMHpBDahZ1N6oEMH/mJBfZ++F3buNRDe/SocUzU2Gu8HsilaQq37xYVp/vM1/VD+Xvi/eOCu+h/sy9hJ7Ev7vcfxgFDSB6BHTa4w84q41U2XrQmx0EIDmd7FaFWS+36Zz9/KuXKF0NgHwIFRku39ZVvfrcHVbpe8xAX3Ti9eUrJ0WG6g8pL+Dl7JGIsovYMGxGsDn/t1Rix9TSVShLueZMqnLdjAEQ1pmZ5DPq8WcWJqeFVh9DyOPkZG2Cq;25:H81eIxmNAAPH10FsqXxb/jfh6B9qGNNZor6u4yVPhVPMUTiG0Bmf+fKb11QCGC+FNPjXwyvBtuPnGISxU+P0OACR/fzco5w5JUQUyiFr1MffJSYsT67l3UFPBiJKx7ra8K8pjx5MK1lFSDJIvKN2c8QwafoTg2WMLW+fI1nXygRl8GW8960jVfjtpuL9vNZKWGYtk3DYKmUoMq1U+NptFH1YTsGy0CyjKR4OStDQQvtv/gyxPBACy6r4LqmtfsCAF0vTC5BHw7yu6kP4i2xZATazcW6CZXc8oM4tW8k7VrORsEszvtj7JsYuXGMWJvJX+HT7PMzF0HE/WNoiS6XE6w==;31:ho4X4Iff0SBahJzBawmWKPv5rx2vaFyy5QszYgv6PWWsOQfV3UvTeasI6nGf6eWenKLfdpGeVpSTiY0Qufgf7iwMCvM2ikK1VhtF0QAKB06aRFSW8gIlaZ/uUDZjjuPweHQEuvE7w82q8Q+V9b+iUQIjWL0lmj7kJDdzzsAiazTOHnUSqD22jMV1ELallr8ukeG+NchybnJIxxoQ71hCrjUTIz7yoB29rRti1Pc58Sw= X-MS-TrafficTypeDiagnostic: VI1PR03MB2894: X-Microsoft-Exchange-Diagnostics: 1;VI1PR03MB2894;20:0SxoH6QNx7pHq9SwDarJv2bPt6yGQs+t+F8pt8hXDnmJs9OVFcTztNLS+9B16pwj1brP8nqERgzx1VpEPKs5KypA0nvOqMPH/JS2+YKbARAunhPXKUWmJmu4X+vwSIvES5xqTKkjIe8n5UlnAyu8gtsnbkN2jFe7xsCcvaqUDD3Xa5DKwQqq08TdBd9QOABjmEag9A1NNcrw16suv2fPevzn8OuAUie8u6Kn3PMT5ZzG3rgcym1v1h7cjfTI0eEQ0ihf5N+999nrMEgQZixixE2iqqL4MiUSgdupmW8QQQ5KNsqYgUpY8euKwPo7fb6Ei/hE8q3yjey0r1Ahb1ucyNxh/btcc/V/9QULUkyH846D1lSFfMQtiRE7jzmGM9BYQR18UiqkmOmxjU5sTd/zln+YN67makoX4aRe3wTFxp8ayN8jK3nCn6cwojyQ70eoomRXUQMTlwF9yd9NHzZympw4hcyfYmwP1vJEb8zksF34iY4m32Ou9nV6u8WliZyL X-Exchange-Antispam-Report-Test: UriScan:(58145275503218)(84791874153150)(114974198459425)(278021516957215)(17755550239193); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR03MB2894;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR03MB2894; X-Microsoft-Exchange-Diagnostics: 1;VI1PR03MB2894;4:Yu+mQqQClkGsi/BnTZOnQX3QJi8cRLN7qkEry4XZ6iK10xm2d9ek9m4BkqBoBEFgr15ul1w3iF/kPBA76XjHxj0GZZ3olWUDG+2wuARU2eViAqswWNEjSa8f7+TbbWFLLwecHq+XSWpIbcgqPBl/fSZu6TRF97MNOe399agBRWjWH+fgoN/DtMKcJ7TUVJ6YLDTMSHE8XQDiMB1ImaepH8+9jdqvm5VNGcBuVrzaVTnBunitXPLUEHqmUZF7MNWb/l/lUxeGOV46Fb/HtEauVC83UMx4ZYNOrCHI6BAkrrqCS5CmuEmiwsm3CSSXn07vm/37ecn/qOvZpp1KGF3YtoHtTiophVpWsTskFjLLTdPtXu2qp8zhmVRRosWkY4UgExZ7vGHSFLzaAn2fmwgCLzX2nMYe4d/Tz8PP5DkmCz0F44mvf8A87z9R3h+V+dFR X-Forefront-PRVS: 042857DBB5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(7370300001)(6049001)(6009001)(189002)(24454002)(504964003)(199003)(2906002)(31696002)(189998001)(7416002)(65826007)(80792005)(33646002)(47776003)(5660300001)(966005)(86362001)(305945005)(6666003)(72206003)(4001350100001)(7736002)(2950100002)(97736004)(66066001)(68736007)(64126003)(65806001)(53936002)(53546010)(65956001)(6916009)(6306002)(110136004)(23676002)(101416001)(6246003)(4326008)(50986999)(76176999)(54356999)(7350300001)(3846002)(6116002)(105586002)(106356001)(42186005)(50466002)(230700001)(36756003)(478600001)(77096006)(81156014)(25786009)(83506001)(8676002)(81166006)(6486002)(229853002)(316002)(31686004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR03MB2894;H:[10.17.182.87];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAzTUIyODk0OzIzOmZIbzFNb0RUTHY3azdQOWRDdEpUTmV0Nm9o?= =?utf-8?B?WkM2emUrdHhodmQ3a1VuTU1xU3Vzb3k2bm9raDFEQURidG8vTDhIOVJVZC9w?= =?utf-8?B?SC9kN3l2UkZtaWZZajVtaDMxNEVtZEJ2RHRCUTdPakJITFcxQnprY1drYUJE?= =?utf-8?B?OWRRMzRBU1BFNllxWkVKZlZGcU10NXVWRUZWSnhTeGVLQWRKcDBqdjRHckRy?= =?utf-8?B?SER1UWg2OVZzQ3VzZFZEQWI3dnJXTUdscTZkUk4waUJsY2RVeU9IVXRJZklG?= =?utf-8?B?d1JyMEJYbVBZVDBVRERGZUZ2blU4UzJTais3UzJsM3crY3BLNWd5NXJHbWY2?= =?utf-8?B?MndLOGtNQW9WUjNXQmxtQVNycG9jL0U4Y3QwZXduN3hSbUZBdXB6emVLUGhp?= =?utf-8?B?L045aXB5eE1MZll4MEt4c2MvNWRoRGJVZEJabUV1SFRIZjdWQkJoWlR6ajJa?= =?utf-8?B?RDBkVE9ZbFJXZ1F4Qy8rNy9nTHUvTzZtaWwrYlgxQm9GRUJOTmVWL04zd2c2?= =?utf-8?B?cXpobXY3V3BSbUh3Q3hTNEhCc0JOcXgwMG9vVFovbjllRHhEaEJwTnZFenZh?= =?utf-8?B?ZzVCZFRJQXU0TjByRzdxMmhBSW9IczVuUjdHbTRaaktObXY2WnNZZktaWmJ4?= =?utf-8?B?RGRSQTIzNVpoNmwvc0tSZlJiVnJ6U1lET3QrOTRvYzRmTUxKYm5GR01kcHgr?= =?utf-8?B?bk9ld2Fyb2ljblMyT0V2L2djMGwzeW9rdWJ6UmpPdkRMNlZQaVNtbUxJYUFN?= =?utf-8?B?QVZKODhNTFlKZG1CSDk2WXJGaktMOEZYTXlpd2p4TXlTcUhLSGs5S3N0Z29N?= =?utf-8?B?NFZab2JqVDY5b0lVaFQrcjczeXdoSkIvS1FJd055c282UCs3RUxFWlozNU9J?= =?utf-8?B?Y1BpYW5KQlhpNForUmJpMUZOYmhMQ0VnSjNUMVN6SmxyKzJqRHpEOGszTTRj?= =?utf-8?B?cGtqLzUvODVTeEhYRHdyeUJlMTltUUYwbEw1VVZnVUdIWkMwaGdaVkhoSWg0?= =?utf-8?B?eEVjRDF0YlpsUnd3cEQ4WS9RdEFQOExaOTFLL1V5dTB3bkNiZ2FKRHgxNnF4?= =?utf-8?B?YnRQYWJxQng1bTkwS09UbmV5Z2Y2THVqU3lWZVRKeUhJdXVWOW1pQUZobFB6?= =?utf-8?B?VGR6cjRiV1dmKzI0VkkyajFlbERPSmZ1VWlib0ljd2FVc0xiR1piZWpDYUov?= =?utf-8?B?RHRHd3RiZkFwZ1JSa0dQSlppdHIvY0xXeFdQRWkrLy9aS1ZZSXhzWjd4d1Zu?= =?utf-8?B?aXEyTmV2aWdLWUNIbGVSUnlQM0c5NEx6elpYaUhTa0pHOHZ4bmxwK0wrY0pK?= =?utf-8?B?alBJOU4rRjNRY0R3VWZFY2d1MWZmclVXcDkvRHQvMkdhbS9KWjJ0VnZvUFht?= =?utf-8?B?ajYxYlk4T0RrbE9ldmdXSldsMDdWcmgwTUNUOVBScG41b0pMYzR1TnM4MXdw?= =?utf-8?B?MkZLQURxNXY5Q2hVd21TTTkyWkpSMlhzQit3RzcwVFZVVlBuaVZNaWs0amd4?= =?utf-8?B?cVE2NnZwdEl1cEhWMSswZVlmZUcwKzZWd045aTdnZi9XN01DK05tUVhmSTIy?= =?utf-8?B?dDFZeXJmRVoweXdjQkRCZDZ6V21GbksvZDNsbzR2SVV0NTdpVWJHaXRDazFN?= =?utf-8?B?UGE2SFNjVGQzTTkwOVlGc1pCMWpvZmR1dU1ja3hkMFFXamRac1V6RzdvSits?= =?utf-8?B?a3F0YitUMmdKV2tzeXQrSnFldmM4WmxHRFNwMkZNUURlZ0dtd1pDNUxUVWp0?= =?utf-8?B?SUdyRFdvTGhqeGtlRkwwNyt6enQ4R2EwVHZ2djRBek5jakc0ajJSNUlmWWR1?= =?utf-8?B?cGdQRU1oeVkzMnBraTlxMHdNU3dFQ21sQTVxMlhFZC93QWpxckFqZlJHencx?= =?utf-8?B?cjBLUHh4NC8yY1Ntc0JkZVo2Y2dkTDl1cUVndFV1eUdPMGpDMDNJb2F4MzZI?= =?utf-8?B?Q2FMK1hobGN2U1hhT1FMMFVQMFFBU1JJWGVsU2t5SzNnb2NqWjhGSCt2bUlm?= =?utf-8?B?T05yWjk2SVBOQ1AxMjlaQzR0SGlha3dyVUx4dz09?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR03MB2894;6:SQ9aybJiHZiaYWznw/li9E5agmUNlgX1ujpmBUmLn9aN8U2+jLcf6vCTgJOtiYanKkK86iL61qjUvJ5QcpWCl1b5AoNIB0U13OFraBV8Ln0r3P0pEipxn0b07Wj5YUadOWp0LjTsAH2rWAAW/Es93AYvy/km0gK7h0uZsRCu0Oja3TVgwzx5yKbtuCbO8IVG9Kp5AFCGKiCmGuqjbl7Fpbwa/My6nZW6HcWVtGjPw61dcFVjkL5Syl8faZAhi+KgEGGZMdUlSxvJV19Ytz29RZBmr/ZHCJJf3fqN7w67l4lZdjIPjrhqwwhl9xUiZV14UthZ7PIlyW3R36nZhJxUQA==;5:Ki5rfHJJqbC7o/ESF/vaXuSuXUmEzEw2sYPq9qgpYUnt/cm9RxMou8YqQmx6fPYiVowQ7QzJPOQYNLhs4dBnFL5EAZy8PkBXiAaupb7moZ2ydHRpUujXxyJGcaVz1vPiJMC2Wfjwzr7q3dkNk0GnDg==;24:ONE1GFLwUVAeCqKcZjGH8XllFbTocCvUz4CYgxXXB7w8GWWfDu0mmx6UN9G4jNDfv4Gng0jUerh+WiCnAZ6Cv1tJaB8Lq2flSIrNmY2cBsw=;7:wi4t3NWurSkFpiHNeTG7ptGoEWbBJFLvmK14o3O+kN3MrhamqIRU6mLH8Gfjp6LXhQdgwgRFw3WL4jbHLfwWkPqOqy4UByIvjcvlJbWlq+/LgxSUyzvQOFskxbDAspcevDrr61KlEFIEIXEpTcFef4xaEnZxm3fZzM5Pz0437JtfDZWQOQCyHNjQOJbI0tT2R2ZOZpTcfO1cZeWcVyiOUt3cUwUilt8UkuV4AKc90n0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2017 10:52:40.6140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB2894 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, all. Gentle reminder. On 05.09.17 19:52, Oleksandr wrote: > > Hi, Magnus, maintainers, all. > > On 19.06.17 14:04, Magnus Damm wrote: >> iommu/ipmmu-vmsa: r8a7796 support V4 >> >> [PATCH v4 1/3] iommu/ipmmu-vmsa: Add r8a7796 DT binding >> [PATCH v4 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48 >> [PATCH v4 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code >> >> This series adds r8a7796 support to the IPMMU driver. The DT binding >> gets updated, maximum number of micro-TLBs are increased and the >> driver is adjusted to match on the new DT binding. > I am interested in adding IPMMU-VMSA support to Xen hypervisor. > > I did some preparations for making IPMMU-VMSA to feel comfortable [1] > inside Xen > followed by direct porting Linux IPMMU-VMSA driver and ARM LPAE > page-table allocator [2] to it. > > I decided to base on the "BSP" driver [3] because it had more complete > support than the "mainline" one [4]. > > During review I got a feedback that "BSP" driver wasn't the best > choice to be ported. > Xen ARM maintainers worry about "BSP" driver which haven't had a > thorough review by the Linux community and as the result might have > bugs which will never be fixed, etc. > > So, for the IPMMU-VMSA support to be accepted by Xen community I > should either write our own driver based on BSP/mainline/whatever > which contains only relevant to Xen things or > direct port from "mainline" driver. As the second option relies on the > required support [5] which isn't in mainline yet, it is not clear when > this support gets merged and how it will be modified/reworked before, > we preliminarily decided to follow the first option. But, I would like > to consider second option again. Despite the complexity of second > option, it has one significant benefit. > > I see that Linux driver is being developed quite actively and looking > over all related patch series I got a feeling that required support > was about to reach upstream. > > Could you, please, clarify some questions which, I hope, help us to > make a decision: > 1. Do you have approximate time-frame for getting this support in? > 2. Are fundamental/significant changes planned for this support? > > Also, may I ask for a link to github branch which contains current > (and likely r8a7795 and 32-bit ARM update) patch series? > > Thank you in advance! > > And sorry for the most likely incorrect format of this email. > > [1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg115901.html > [2] https://lists.xen.org/archives/html/xen-devel/2017-07/msg02679.html > [3] > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/tree/drivers/iommu/ipmmu-vmsa.c?h=v4.9/rcar-3.5.3 > [4] > http://elixir.free-electrons.com/linux/latest/source/drivers/iommu/ipmmu-vmsa.c > [5] > https://lists.linuxfoundation.org/pipermail/iommu/2017-June/022567.html > https://lists.linuxfoundation.org/pipermail/iommu/2017-June/022577.html > https://lkml.org/lkml/2017/7/17/393 >> >> Changes since V3: >> - Rebased on top of [PATCH v4 00/09] iommu/ipmmu-vmsa: r8a7795 >> support V4 >> - Patch 3/3 updated with Reviewed-by - thanks Geert! >> >> Changes since V2: >> - Patch 2/3 updated with an outer set of () - thanks Ramesh! >> - Patch 2/3 updated with Reviewed-by - thanks Geert! >> - Patch 3/3 updated to include white list support >> >> Changes since V1: >> - Patch 1/3 updated with more Acked-by tags >> - Patch 2/3 updated with high I/O register range support >> >> Patch 1/3 is ready for upstream merge and includes the following tags: >> Signed-off-by: Magnus Damm >> Acked-by: Laurent Pinchart >> Acked-by: Rob Herring >> Acked-by: Simon Horman >> Acked-by: Geert Uytterhoeven >> >> Patch 2/3 and 3/3 are quite trivial but have no acked-by so far. >> >> Signed-off-by: Magnus Damm >> --- >> >> Developed on top of next-20170614 with the following series applied >> [PATCH 00/04] iommu/ipmmu-vmsa: 32-bit ARM update >> [PATCH v4 00/09] iommu/ipmmu-vmsa: r8a7795 support V4 >> >> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt | 1 >> drivers/iommu/ipmmu-vmsa.c | 24 +++++++--- >> 2 files changed, 18 insertions(+), 7 deletions(-) >