From: Randy Dunlap <rdunlap@infradead.org>
To: Arnd Bergmann <arnd@kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Chen Yu <yu.c.chen@intel.com>,
Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] intel_idle: fix intel_idle_state_needs_timer_stop build failure
Date: Thu, 3 Dec 2020 15:12:23 -0800 [thread overview]
Message-ID: <9f5a56dc-d558-b63b-9ebe-5b935a46ba8b@infradead.org> (raw)
In-Reply-To: <20201203223020.1173185-1-arnd@kernel.org>
On 12/3/20 2:30 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added function is defined inside of an #ifdef section but
> used outside, leading to a build failure:
>
> drivers/idle/intel_idle.c:1510:7: error: implicit declaration of function 'intel_idle_state_needs_timer_stop' [-Werror,-Wimplicit-function-declaration]
> if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count]))
> ^
>
> Move it ahead of the CONFIG_ACPI_PROCESSOR_CSTATE check.
>
> Fixes: 6e1d2bc675bd ("intel_idle: Fix intel_idle() vs tracing")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/idle/intel_idle.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
Peter has already fixed this one.
thanks.
--
~Randy
prev parent reply other threads:[~2020-12-03 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 22:30 [PATCH] intel_idle: fix intel_idle_state_needs_timer_stop build failure Arnd Bergmann
2020-12-03 23:12 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f5a56dc-d558-b63b-9ebe-5b935a46ba8b@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@suse.de \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).